panda: using reference in loop (#33554)

using reference in loop
pull/33556/head
Dean Lee 9 months ago committed by GitHub
parent fa892a9755
commit 50b0089602
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 4
      selfdrive/pandad/panda.cc

@ -47,7 +47,7 @@ std::vector<std::string> Panda::list(bool usb_only) {
#ifndef __APPLE__
if (!usb_only) {
for (auto s : PandaSpiHandle::list()) {
for (const auto &s : PandaSpiHandle::list()) {
if (std::find(serials.begin(), serials.end(), s) == serials.end()) {
serials.push_back(s);
}
@ -169,7 +169,7 @@ void Panda::pack_can_buffer(const capnp::List<cereal::CanData>::Reader &can_data
int32_t pos = 0;
uint8_t send_buf[2 * USB_TX_SOFT_LIMIT];
for (auto cmsg : can_data_list) {
for (const auto &cmsg : can_data_list) {
// check if the message is intended for this panda
uint8_t bus = cmsg.getSrc();
if (bus < bus_offset || bus >= (bus_offset + PANDA_BUS_OFFSET)) {

Loading…
Cancel
Save