From 50b0089602bbc0f600d360c40d3fb307579b41f8 Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Sat, 14 Sep 2024 02:13:47 +0800 Subject: [PATCH] panda: using reference in loop (#33554) using reference in loop --- selfdrive/pandad/panda.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/selfdrive/pandad/panda.cc b/selfdrive/pandad/panda.cc index bc81d7de91..4376d85795 100644 --- a/selfdrive/pandad/panda.cc +++ b/selfdrive/pandad/panda.cc @@ -47,7 +47,7 @@ std::vector Panda::list(bool usb_only) { #ifndef __APPLE__ if (!usb_only) { - for (auto s : PandaSpiHandle::list()) { + for (const auto &s : PandaSpiHandle::list()) { if (std::find(serials.begin(), serials.end(), s) == serials.end()) { serials.push_back(s); } @@ -169,7 +169,7 @@ void Panda::pack_can_buffer(const capnp::List::Reader &can_data int32_t pos = 0; uint8_t send_buf[2 * USB_TX_SOFT_LIMIT]; - for (auto cmsg : can_data_list) { + for (const auto &cmsg : can_data_list) { // check if the message is intended for this panda uint8_t bus = cmsg.getSrc(); if (bus < bus_offset || bus >= (bus_offset + PANDA_BUS_OFFSET)) {