sadmen
/
openpilot_comma
mirror of https://github.com/commaai/openpilot.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Honda: fix controls mismatch for stock PCM configs (#23662)

Browse Source 
* Honda: fix controls mismatch for stock PCM configs

* ready to remove

* bump panda
pull/23616/head
Adeeb Shihadeh 3 years ago committed by GitHub
parent a584436328
commit 5219554b85
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 7 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 2
      panda
  2. 6
      selfdrive/test/test_models.py

2
panda

@ -1 +1 @@
Subproject commit 3ddec2d221ee414017082b00e0e8af840e7e99c6 Subproject commit bdb591f5e68f12c5b5fad60f331192abc2e1fd92

6
selfdrive/test/test_models.py
Unescape View File

@ -211,12 +211,6 @@ class TestCarModel(unittest.TestCase):
if failed_checks['brakePressed'] < 150: if failed_checks['brakePressed'] < 150:
del failed_checks['brakePressed'] del failed_checks['brakePressed']
# TODO: use the same signal in panda and carState
# tolerate a small delay between the button press and PCM entering a cruise state
if self.car_model == HONDA.ACCORD:
if failed_checks['controlsAllowed'] < 500:
del failed_checks['controlsAllowed']
self.assertFalse(len(failed_checks), f"panda safety doesn't agree with CarState: {failed_checks}") self.assertFalse(len(failed_checks), f"panda safety doesn't agree with CarState: {failed_checks}")
if __name__ == "__main__": if __name__ == "__main__":

Write Preview
Loading…
Cancel
Save