From 55f88260d13d917ab93e32bea4a53257bca02065 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 1 Feb 2024 02:28:00 -0600 Subject: [PATCH] Mazda: use bus 0 to fingerprint (#31261) * for testing * switch OBD port to logging * revert * cmt * cmt * remove OBD query * Update selfdrive/car/mazda/values.py old-commit-hash: f0b6f489489731b4d968880d6d9e5a58dbc14035 --- selfdrive/car/mazda/values.py | 7 +------ selfdrive/car/tests/test_fw_fingerprint.py | 4 ++-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/selfdrive/car/mazda/values.py b/selfdrive/car/mazda/values.py index c95ae162f9..b43ab3df66 100644 --- a/selfdrive/car/mazda/values.py +++ b/selfdrive/car/mazda/values.py @@ -67,16 +67,11 @@ class Buttons: FW_QUERY_CONFIG = FwQueryConfig( requests=[ - Request( - [StdQueries.MANUFACTURER_SOFTWARE_VERSION_REQUEST], - [StdQueries.MANUFACTURER_SOFTWARE_VERSION_RESPONSE], - ), - # Log responses on powertrain bus + # TODO: check data to ensure ABS does not skip ISO-TP frames on bus 0 Request( [StdQueries.MANUFACTURER_SOFTWARE_VERSION_REQUEST], [StdQueries.MANUFACTURER_SOFTWARE_VERSION_RESPONSE], bus=0, - logging=True, ), ], ) diff --git a/selfdrive/car/tests/test_fw_fingerprint.py b/selfdrive/car/tests/test_fw_fingerprint.py index 620fa25691..f2de3ab770 100755 --- a/selfdrive/car/tests/test_fw_fingerprint.py +++ b/selfdrive/car/tests/test_fw_fingerprint.py @@ -246,7 +246,7 @@ class TestFwFingerprintTiming(unittest.TestCase): @pytest.mark.timeout(60) def test_fw_query_timing(self): - total_ref_time = 6.9 + total_ref_time = 6.8 brand_ref_times = { 1: { 'gm': 0.5, @@ -255,7 +255,7 @@ class TestFwFingerprintTiming(unittest.TestCase): 'ford': 0.1, 'honda': 0.55, 'hyundai': 0.65, - 'mazda': 0.2, + 'mazda': 0.1, 'nissan': 0.8, 'subaru': 0.45, 'tesla': 0.2,