From 578b8fba1a853da2f3b0d44605abfdd019bedd2f Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Thu, 15 Sep 2022 03:33:56 +0800
Subject: [PATCH] networking: create scanning label once (#25782)

* create scanning label only once

* rename

* fix

Co-authored-by: Shane Smiskol <shane@smiskol.com>
---
 selfdrive/ui/qt/offroad/networking.cc | 25 +++++++++++++------------
 selfdrive/ui/qt/offroad/networking.h  |  2 ++
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/selfdrive/ui/qt/offroad/networking.cc b/selfdrive/ui/qt/offroad/networking.cc
index c7341d1987..7ec8691feb 100644
--- a/selfdrive/ui/qt/offroad/networking.cc
+++ b/selfdrive/ui/qt/offroad/networking.cc
@@ -207,9 +207,12 @@ WifiUI::WifiUI(QWidget *parent, WifiManager* wifi) : QWidget(parent), wifi(wifi)
   checkmark = QPixmap(ASSET_PATH + "offroad/icon_checkmark.svg").scaledToWidth(49, Qt::SmoothTransformation);
   circled_slash = QPixmap(ASSET_PATH + "img_circled_slash.svg").scaledToWidth(49, Qt::SmoothTransformation);
 
-  QLabel *scanning = new QLabel(tr("Scanning for networks..."));
-  scanning->setStyleSheet("font-size: 65px;");
-  main_layout->addWidget(scanning, 0, Qt::AlignCenter);
+  scanningLabel = new QLabel(tr("Scanning for networks..."));
+  scanningLabel->setStyleSheet("font-size: 65px;");
+  main_layout->addWidget(scanningLabel, 0, Qt::AlignCenter);
+
+  list_layout = new QVBoxLayout;
+  main_layout->addLayout(list_layout);
 
   setStyleSheet(R"(
     QScrollBar::handle:vertical {
@@ -257,14 +260,12 @@ WifiUI::WifiUI(QWidget *parent, WifiManager* wifi) : QWidget(parent), wifi(wifi)
 
 void WifiUI::refresh() {
   // TODO: don't rebuild this every time
-  clearLayout(main_layout);
+  clearLayout(list_layout);
+
+  bool is_empty = wifi->seenNetworks.isEmpty();
+  scanningLabel->setVisible(is_empty);
+  if (is_empty) return;
 
-  if (wifi->seenNetworks.size() == 0) {
-    QLabel *scanning = new QLabel(tr("Scanning for networks..."));
-    scanning->setStyleSheet("font-size: 65px;");
-    main_layout->addWidget(scanning, 0, Qt::AlignCenter);
-    return;
-  }
   QList<Network> sortedNetworks = wifi->seenNetworks.values();
   std::sort(sortedNetworks.begin(), sortedNetworks.end(), compare_by_strength);
 
@@ -327,6 +328,6 @@ void WifiUI::refresh() {
 
     list->addItem(hlayout);
   }
-  main_layout->addWidget(list);
-  main_layout->addStretch(1);
+  list_layout->addWidget(list);
+  list_layout->addStretch(1);
 }
diff --git a/selfdrive/ui/qt/offroad/networking.h b/selfdrive/ui/qt/offroad/networking.h
index e78d65ef0f..4fc9a53d93 100644
--- a/selfdrive/ui/qt/offroad/networking.h
+++ b/selfdrive/ui/qt/offroad/networking.h
@@ -17,6 +17,8 @@ public:
 
 private:
   WifiManager *wifi = nullptr;
+  QVBoxLayout *list_layout = nullptr;
+  QLabel *scanningLabel = nullptr;
   QVBoxLayout* main_layout;
   QPixmap lock;
   QPixmap checkmark;