From 586d535595a549eb9ab5d33a95de046df1a979ea Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Mon, 24 Jul 2023 16:38:21 -0700 Subject: [PATCH] since we don't have map, use enabled --- selfdrive/ui/qt/onroad.cc | 12 +++++++++--- selfdrive/ui/qt/onroad.h | 4 ++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/selfdrive/ui/qt/onroad.cc b/selfdrive/ui/qt/onroad.cc index 81f08c0e54..069eed5e7a 100644 --- a/selfdrive/ui/qt/onroad.cc +++ b/selfdrive/ui/qt/onroad.cc @@ -93,7 +93,7 @@ void OnroadWindow::offroadTransition(bool offroad) { QObject::connect(m, &MapPanel::mapPanelRequested, this, &OnroadWindow::mapPanelRequested); QObject::connect(nvg->map_settings_btn, &MapSettingsButton::clicked, m, &MapPanel::toggleMapSettings); - nvg->map_settings_btn->setVisible(true); + nvg->map_settings_btn->setEnabled(true); m->setFixedWidth(topWidget(this)->width() / 2 - UI_BORDER_SIZE); split->insertWidget(0, m); @@ -230,6 +230,7 @@ MapSettingsButton::MapSettingsButton(QWidget *parent) : QPushButton(parent) { // hidden by default, made visible if map is created (has prime or mapbox token) setVisible(false); + setEnabled(false); } void MapSettingsButton::paintEvent(QPaintEvent *event) { @@ -305,12 +306,17 @@ void AnnotatedCameraWidget::updateState(const UIState &s) { setProperty("speed", cur_speed); setProperty("setSpeed", set_speed); setProperty("speedUnit", s.scene.is_metric ? tr("km/h") : tr("mph")); - setProperty("hideDM", (cs.getAlertSize() != cereal::ControlsState::AlertSize::NONE)); + setProperty("hideLowerIcons", (cs.getAlertSize() != cereal::ControlsState::AlertSize::NONE)); setProperty("status", s.status); // update engageability/experimental mode button experimental_btn->updateState(s); + // hide map settings button for alerts + if (map_settings_btn->isEnabled()) { + map_settings_btn->setVisible(!hideLowerIcons); + } + // update DM icon auto dm_state = sm["driverMonitoringState"].getDriverMonitoringState(); setProperty("dmActive", dm_state.getIsActiveMode()); @@ -677,7 +683,7 @@ void AnnotatedCameraWidget::paintGL() { } // DMoji - if (!hideDM && (sm.rcv_frame("driverStateV2") > s->scene.started_frame)) { + if (!hideLowerIcons && (sm.rcv_frame("driverStateV2") > s->scene.started_frame)) { update_dmonitoring(s, sm["driverStateV2"].getDriverStateV2(), dm_fade_state, rightHandDM); drawDriverState(painter, s); } diff --git a/selfdrive/ui/qt/onroad.h b/selfdrive/ui/qt/onroad.h index 2460d03b60..445081d937 100644 --- a/selfdrive/ui/qt/onroad.h +++ b/selfdrive/ui/qt/onroad.h @@ -73,7 +73,7 @@ class AnnotatedCameraWidget : public CameraWidget { Q_PROPERTY(bool is_metric MEMBER is_metric); Q_PROPERTY(bool dmActive MEMBER dmActive); - Q_PROPERTY(bool hideDM MEMBER hideDM); + Q_PROPERTY(bool hideLowerIcons MEMBER hideLowerIcons); Q_PROPERTY(bool rightHandDM MEMBER rightHandDM); Q_PROPERTY(int status MEMBER status); @@ -95,7 +95,7 @@ private: bool is_cruise_set = false; bool is_metric = false; bool dmActive = false; - bool hideDM = false; + bool hideLowerIcons = false; bool rightHandDM = false; float dm_fade_state = 1.0; bool has_us_speed_limit = false;