op.sh: lint (#33217)
* redo
* better
* fix this
* clean everything
* all files
* test
* debug
* get info
* revert
* only good files
* allow skip
* also this
* help section
old-commit-hash: f8f6c39915
pull/33302/head
Maxime Desroches
9 months ago
committed by
GitHub
parent
7f4f1d4c5f
commit
5b82b7c65e
4 changed files with 158 additions and 15 deletions
@ -1,11 +1,99 @@ |
||||
#!/bin/bash |
||||
set -e |
||||
|
||||
RED='\033[0;31m' |
||||
GREEN='\033[0;32m' |
||||
UNDERLINE='\033[4m' |
||||
BOLD='\033[1m' |
||||
NC='\033[0m' |
||||
|
||||
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )" |
||||
cd $DIR/../ |
||||
|
||||
# TODO: bring back rest of pre-commit checks: |
||||
# https://github.com/commaai/openpilot/blob/4b11c9e914707df9def598616995be2a5d355a6a/.pre-commit-config.yaml#L2 |
||||
FAILED=0 |
||||
|
||||
IGNORED_FILES="uv\.lock|docs\/CARS.md" |
||||
IGNORED_DIRS="^third_party.*|^msgq.*|^msgq_repo.*|^opendbc.*|^opendbc_repo.*|^cereal.*|^panda.*|^rednose.*|^rednose_repo.*|^tinygrad.*|^tinygrad_repo.*|^teleoprtc.*|^teleoprtc_repo.*" |
||||
|
||||
function run() { |
||||
shopt -s extglob |
||||
case $1 in |
||||
$SKIP ) return 0 ;; |
||||
esac |
||||
|
||||
echo -en "$1" |
||||
|
||||
for ((i=0; i<$((50 - ${#1})); i++)); do |
||||
echo -n "." |
||||
done |
||||
|
||||
shift 1; |
||||
CMD="$@" |
||||
|
||||
set +e |
||||
log="$((eval "$CMD" ) 2>&1)" |
||||
|
||||
if [[ $? -eq 0 ]]; then |
||||
echo -e "[${GREEN}✔${NC}]" |
||||
else |
||||
echo -e "[${RED}✗${NC}]" |
||||
echo "$log" |
||||
FAILED=1 |
||||
fi |
||||
set -e |
||||
} |
||||
|
||||
function run_tests() { |
||||
ALL_FILES=$1 |
||||
PYTHON_FILES=$2 |
||||
|
||||
run "ruff" ruff check $PYTHON_FILES --quiet |
||||
run "lint-imports" lint-imports |
||||
run "check_added_large_files" python3 -m pre_commit_hooks.check_added_large_files --enforce-all $ALL_FILES --maxkb=120 |
||||
run "check_shebang_scripts_are_executable" python3 -m pre_commit_hooks.check_shebang_scripts_are_executable $ALL_FILES |
||||
|
||||
if [[ -z "$FAST" ]]; then |
||||
run "mypy" mypy $PYTHON_FILES |
||||
run "codespell" codespell $ALL_FILES |
||||
fi |
||||
|
||||
return $FAILED |
||||
} |
||||
|
||||
function help() { |
||||
echo "A fast linter" |
||||
echo "" |
||||
echo -e "${BOLD}${UNDERLINE}Usage:${NC} op lint [OPTIONS]" |
||||
echo "" |
||||
echo -e "${BOLD}${UNDERLINE}Options:${NC}" |
||||
echo -e " ${BOLD}-f, --fast${NC}" |
||||
echo " Skip slow tests" |
||||
echo -e " ${BOLD}-s, --skip${NC}" |
||||
echo " Specify a test to skip" |
||||
echo "" |
||||
echo -e "${BOLD}${UNDERLINE}Examples:${NC}" |
||||
echo " op lint --skip mypy --skip ruff" |
||||
echo " Skip the ruff and mypy check" |
||||
} |
||||
|
||||
while true; do |
||||
case $1 in |
||||
-f | --fast ) shift 1; FAST="1" ;; |
||||
-s | --skip ) shift 1; SKIP+="$1|"; shift 1 ;; |
||||
-h | --help | -help | --h ) help; exit 0 ;; |
||||
* ) break ;; |
||||
esac |
||||
done |
||||
|
||||
SKIP="@($(echo $SKIP | sed 's/|$//'))" |
||||
|
||||
GIT_FILES="$(git ls-files | sed -E "s/$IGNORED_FILES|$IGNORED_DIRS//g")" |
||||
ALL_FILES="" |
||||
for f in $GIT_FILES; do |
||||
if [[ -f $f ]]; then |
||||
ALL_FILES+="$f"$'\n' |
||||
fi |
||||
done |
||||
PYTHON_FILES=$(echo "$ALL_FILES" | grep --color=never '.py$' || true) |
||||
|
||||
ruff check . |
||||
lint-imports |
||||
run_tests "$ALL_FILES" "$PYTHON_FILES" |
||||
|
||||
Loading…
Reference in new issue