enable for relay malfunc check

pull/29759/head
Shane Smiskol 2 years ago
parent 257476e368
commit 5e7c5ba438
  1. 14
      selfdrive/car/tests/test_models.py

@ -232,10 +232,11 @@ class TestCarModelBase(unittest.TestCase):
if self.CP.dashcamOnly: if self.CP.dashcamOnly:
self.skipTest("no need to check panda safety for dashcamOnly") self.skipTest("no need to check panda safety for dashcamOnly")
start_ts = self.can_msgs[0].logMonoTime start_ts = self.can_msgs[self.elm_frame].logMonoTime
self.safety.set_relay_malfunction(False)
failed_addrs = Counter() failed_addrs = Counter()
for can in self.can_msgs: for can in self.can_msgs[self.elm_frame:]:
# update panda timer # update panda timer
t = (can.logMonoTime - start_ts) / 1e3 t = (can.logMonoTime - start_ts) / 1e3
self.safety.set_timer(int(t)) self.safety.set_timer(int(t))
@ -255,12 +256,11 @@ class TestCarModelBase(unittest.TestCase):
if t > 1e6: if t > 1e6:
self.assertTrue(self.safety.addr_checks_valid()) self.assertTrue(self.safety.addr_checks_valid())
# No need to check relay malfunction on disabled routes (relay closed) or for reasonable fingerprinting time # No need to check relay malfunction on disabled routes (relay closed)
# TODO: detect when relay has flipped to properly check relay malfunction if self.openpilot_enabled:
if self.openpilot_enabled and t > 5e6:
self.assertFalse(self.safety.get_relay_malfunction()) self.assertFalse(self.safety.get_relay_malfunction())
else: else:
self.safety.set_relay_malfunction(False) self.safety.set_relay_malfunction(False)
self.assertFalse(len(failed_addrs), f"panda safety RX check failed: {failed_addrs}") self.assertFalse(len(failed_addrs), f"panda safety RX check failed: {failed_addrs}")

Loading…
Cancel
Save