From 603bed3a855a89dacd23091603a6286ac99bf4ba Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 8 Jun 2023 22:26:04 -0700 Subject: [PATCH] comment for tomorrow --- selfdrive/car/fw_versions.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/selfdrive/car/fw_versions.py b/selfdrive/car/fw_versions.py index d143629afa..bc5a4a326d 100755 --- a/selfdrive/car/fw_versions.py +++ b/selfdrive/car/fw_versions.py @@ -88,6 +88,9 @@ def match_fw_to_car_fuzzy(fw_versions_dict, config, log=True, exclude=None): for version in versions: # Fall back to matching with full FW versions if brand does not implement platform codes candidates = set() + # TODO: we might want to try both, the only reason we'd want to replace exact with platform codes is if + # previous function was giving us false positives, which it isn't. we lose fuzzy FP for a lot of platforms + # with just platform codes on two ECUs... if config.fuzzy_get_platform_codes is None: # All cars that have this FW response on the specified address candidates = all_fw_versions[(*ecu_key, version)]