From 834f212903f5c06a9fe8d6caa6b6da52ac7a7d83 Mon Sep 17 00:00:00 2001 From: cydia2020 <12470297+cydia2020@users.noreply.github.com> Date: Fri, 16 Sep 2022 10:48:17 +1000 Subject: [PATCH 01/13] Multilang: add missing Chinese e2e toggle translations (#25656) * japanese e2e toggle * chinese (simp) * chinese (trad) * OOPS * Mention experimental in details * Also in traditional * Exp. * suggestions * Apply suggestions from code review Co-authored-by: ZwX1616 * add back removed translations from merge * Update selfdrive/ui/translations/main_zh-CHS.ts Co-authored-by: Shane Smiskol Co-authored-by: ZwX1616 --- selfdrive/ui/translations/main_zh-CHS.ts | 4 ++-- selfdrive/ui/translations/main_zh-CHT.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/selfdrive/ui/translations/main_zh-CHS.ts b/selfdrive/ui/translations/main_zh-CHS.ts index 8fce4e01a7..8a6f856be7 100644 --- a/selfdrive/ui/translations/main_zh-CHS.ts +++ b/selfdrive/ui/translations/main_zh-CHS.ts @@ -1167,7 +1167,7 @@ location set 🌮 End-to-end longitudinal (extremely alpha) 🌮 - + 🌮 端对端纵向控制（实验性功能） 🌮 @@ -1182,7 +1182,7 @@ location set Let the driving model control the gas and brakes. openpilot will drive as it thinks a human would. Super experimental. - + 让驾驶模型直接控制油门和刹车，openpilot将会模仿人类司机的驾驶方式。该功能仍非常实验性。 diff --git a/selfdrive/ui/translations/main_zh-CHT.ts b/selfdrive/ui/translations/main_zh-CHT.ts index 022d41be81..6758305420 100644 --- a/selfdrive/ui/translations/main_zh-CHT.ts +++ b/selfdrive/ui/translations/main_zh-CHT.ts @@ -1169,7 +1169,7 @@ location set 🌮 End-to-end longitudinal (extremely alpha) 🌮 - + 🌮 端對端縱向控制（實驗性功能） 🌮 @@ -1184,7 +1184,7 @@ location set Let the driving model control the gas and brakes. openpilot will drive as it thinks a human would. Super experimental. - + 讓駕駛模型直接控製油門和剎車，openpilot將會模仿人類司機的駕駛方式。該功能仍非常實驗性。 From 1aa8c0525ea5339eecd82cb08572636ebbaa7034 Mon Sep 17 00:00:00 2001 From: Jason Shuler Date: Thu, 15 Sep 2022 20:55:02 -0400 Subject: [PATCH 02/13] GM: Chevy Equinox 2019-22 (#25431) * Chevy Equinox Port * LKAS is not standard on 2019, but it's the same package as ACC. (LKAS standard 2020+) * 2019 here too * clean up * add to untested * not in docs Co-authored-by: Shane Smiskol --- selfdrive/car/gm/interface.py | 10 +++++++++- selfdrive/car/gm/values.py | 8 +++++++- selfdrive/car/tests/routes.py | 1 + selfdrive/car/torque_data/override.yaml | 1 + 4 files changed, 18 insertions(+), 2 deletions(-) diff --git a/selfdrive/car/gm/interface.py b/selfdrive/car/gm/interface.py index be28890484..49d56cf096 100755 --- a/selfdrive/car/gm/interface.py +++ b/selfdrive/car/gm/interface.py @@ -71,7 +71,7 @@ class CarInterface(CarInterfaceBase): # These cars have been put into dashcam only due to both a lack of users and test coverage. # These cars likely still work fine. Once a user confirms each car works and a test route is # added to selfdrive/car/tests/routes.py, we can remove it from this list. - ret.dashcamOnly = candidate in {CAR.CADILLAC_ATS, CAR.HOLDEN_ASTRA, CAR.MALIBU, CAR.BUICK_REGAL} + ret.dashcamOnly = candidate in {CAR.CADILLAC_ATS, CAR.HOLDEN_ASTRA, CAR.MALIBU, CAR.BUICK_REGAL, CAR.EQUINOX} # Start with a baseline tuning for all GM vehicles. Override tuning as needed in each model section below. ret.minSteerSpeed = 10 * CV.KPH_TO_MS @@ -170,6 +170,14 @@ class CarInterface(CarInterfaceBase): tire_stiffness_factor = 1.0 CarInterfaceBase.configure_torque_tune(candidate, ret.lateralTuning) + elif candidate == CAR.EQUINOX: + ret.minEnableSpeed = -1 + ret.mass = 3500. * CV.LB_TO_KG + STD_CARGO_KG + ret.wheelbase = 2.72 + ret.steerRatio = 14.4 + ret.centerToFront = ret.wheelbase * 0.4 + CarInterfaceBase.configure_torque_tune(candidate, ret.lateralTuning) + # TODO: get actual value, for now starting with reasonable value for # civic and scaling by mass and wheelbase ret.rotationalInertia = scale_rot_inertia(ret.mass, ret.wheelbase) diff --git a/selfdrive/car/gm/values.py b/selfdrive/car/gm/values.py index a84cbdc91a..25e624da7b 100644 --- a/selfdrive/car/gm/values.py +++ b/selfdrive/car/gm/values.py @@ -60,6 +60,7 @@ class CAR: ESCALADE_ESV = "CADILLAC ESCALADE ESV 2016" BOLT_EUV = "CHEVROLET BOLT EUV 2022" SILVERADO = "CHEVROLET SILVERADO 1500 2020" + EQUINOX = "CHEVROLET EQUINOX 2019" class Footnote(Enum): @@ -89,6 +90,7 @@ CAR_INFO: Dict[str, Union[GMCarInfo, List[GMCarInfo]]] = { GMCarInfo("Chevrolet Silverado 1500 2020-21", "Safety Package II", footnotes=[], harness=Harness.gm), GMCarInfo("GMC Sierra 1500 2020-21", "Driver Alert Package II", footnotes=[], harness=Harness.gm), ], + CAR.EQUINOX: GMCarInfo("Chevrolet Equinox 2019-22", "Adaptive Cruise Control (ACC)", footnotes=[], harness=Harness.gm), } @@ -166,6 +168,10 @@ FINGERPRINTS = { { 190: 6, 193: 8, 197: 8, 201: 8, 208: 8, 209: 7, 211: 2, 241: 6, 249: 8, 257: 8, 288: 5, 289: 8, 298: 8, 304: 3, 309: 8, 311: 8, 313: 8, 320: 4, 322: 7, 328: 1, 352: 5, 381: 8, 384: 4, 386: 8, 388: 8, 413: 8, 451: 8, 452: 8, 453: 6, 455: 7, 460: 5, 463: 3, 479: 3, 481: 7, 485: 8, 489: 8, 497: 8, 500: 6, 501: 8, 528: 5, 532: 6, 534: 2, 560: 8, 562: 8, 563: 5, 565: 5, 608: 8, 609: 6, 610: 6, 611: 6, 612: 8, 613: 8, 707: 8, 715: 8, 717: 5, 761: 7, 789: 5, 800: 6, 801: 8, 810: 8, 840: 5, 842: 5, 844: 8, 848: 4, 869: 4, 880: 6, 977: 8, 1001: 8, 1011: 6, 1017: 8, 1020: 8, 1033: 7, 1034: 7, 1217: 8, 1221: 5, 1233: 8, 1249: 8, 1259: 8, 1261: 7, 1263: 4, 1265: 8, 1267: 1, 1271: 8, 1280: 4, 1296: 4, 1300: 8, 1930: 7 }], + CAR.EQUINOX: [ + { + 190: 6, 193: 8, 197: 8, 201: 8, 209: 7, 211: 2, 241: 6, 249: 8, 257: 8, 288: 5, 289: 8, 298: 8, 304: 1, 309: 8, 311: 8, 313: 8, 320: 3, 328: 1, 352: 5, 381: 8, 384: 4, 386: 8, 388: 8, 413: 8, 451: 8, 452: 8, 453: 6, 455: 7, 463: 3, 479: 3, 481: 7, 485: 8, 489: 8, 497: 8, 500: 6, 501: 8, 510: 8, 528: 5, 532: 6, 560: 8, 562: 8, 563: 5, 565: 5, 608: 8, 609: 6, 610: 6, 611: 6, 612: 8, 613: 8, 707: 8, 715: 8, 717: 5, 753: 5, 761: 7, 789: 5, 800: 6, 810: 8, 840: 5, 842: 5, 844: 8, 869: 4, 880: 6, 977: 8, 1001: 8, 1011: 6, 1017: 8, 1020: 8, 1033: 7, 1034: 7, 1217: 8, 1221: 5, 1233: 8, 1249: 8, 1259: 8, 1261: 7, 1263: 4, 1265: 8, 1267: 1, 1271: 8, 1280: 4, 1296: 4, 1300: 8, 1930: 7 + }], } DBC: Dict[str, Dict[str, str]] = defaultdict(lambda: dbc_dict('gm_global_a_powertrain_generated', 'gm_global_a_object', chassis_dbc='gm_global_a_chassis')) @@ -173,6 +179,6 @@ DBC: Dict[str, Dict[str, str]] = defaultdict(lambda: dbc_dict('gm_global_a_power EV_CAR = {CAR.VOLT, CAR.BOLT_EUV} # We're integrated at the camera with VOACC on these cars (instead of ASCM w/ OBD-II harness) -CAMERA_ACC_CAR = {CAR.BOLT_EUV, CAR.SILVERADO} +CAMERA_ACC_CAR = {CAR.BOLT_EUV, CAR.SILVERADO, CAR.EQUINOX} STEER_THRESHOLD = 1.0 diff --git a/selfdrive/car/tests/routes.py b/selfdrive/car/tests/routes.py index 1f5d3edaf0..9f28bf8543 100644 --- a/selfdrive/car/tests/routes.py +++ b/selfdrive/car/tests/routes.py @@ -21,6 +21,7 @@ non_tested_cars = [ GM.CADILLAC_ATS, GM.HOLDEN_ASTRA, GM.MALIBU, + GM.EQUINOX, HYUNDAI.ELANTRA_GT_I30, HYUNDAI.GENESIS_G90, HYUNDAI.KIA_OPTIMA_H, diff --git a/selfdrive/car/torque_data/override.yaml b/selfdrive/car/torque_data/override.yaml index 20fb5f7a64..2e0f601e84 100644 --- a/selfdrive/car/torque_data/override.yaml +++ b/selfdrive/car/torque_data/override.yaml @@ -27,6 +27,7 @@ RAM HD 5TH GEN: [1.4, 1.4, 0.0] SUBARU OUTBACK 6TH GEN: [2.3, 2.3, 0.11] CHEVROLET BOLT EUV 2022: [2.0, 2.0, 0.05] CHEVROLET SILVERADO 1500 2020: [1.9, 1.9, 0.112] +CHEVROLET EQUINOX 2019: [2.0, 2.0, 0.05] VOLKSWAGEN PASSAT NMS: [2.5, 2.5, 0.1] HYUNDAI TUCSON HYBRID 4TH GEN: [2.5, 2.5, 0.0] From 5a80fda819fda68cad1caf7c6db15d9a495aefac Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 15 Sep 2022 19:24:18 -0700 Subject: [PATCH 03/13] GM: adjust Bolt EUV centerToFront --- selfdrive/car/gm/interface.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/selfdrive/car/gm/interface.py b/selfdrive/car/gm/interface.py index 49d56cf096..f3ab1ee726 100755 --- a/selfdrive/car/gm/interface.py +++ b/selfdrive/car/gm/interface.py @@ -156,7 +156,7 @@ class CarInterface(CarInterfaceBase): ret.mass = 1669. + STD_CARGO_KG ret.wheelbase = 2.675 ret.steerRatio = 16.8 - ret.centerToFront = ret.wheelbase * 0.4 + ret.centerToFront = 2.15 # measured tire_stiffness_factor = 1.0 ret.steerActuatorDelay = 0.2 CarInterfaceBase.configure_torque_tune(candidate, ret.lateralTuning) From 7ddcde687e3ffaa0ec91002871b76f9ca82752b1 Mon Sep 17 00:00:00 2001 From: eFini Date: Fri, 16 Sep 2022 10:31:57 +0800 Subject: [PATCH 04/13] Multilang: add missing Chinese (Traditional) translations (#25802) --- selfdrive/ui/translations/main_zh-CHT.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/selfdrive/ui/translations/main_zh-CHT.ts b/selfdrive/ui/translations/main_zh-CHT.ts index 6758305420..ef958e7140 100644 --- a/selfdrive/ui/translations/main_zh-CHT.ts +++ b/selfdrive/ui/translations/main_zh-CHT.ts @@ -985,42 +985,42 @@ location set Updates are only downloaded while the car is off. - + 系統更新只會在熄火時下載。 Current Version - + 當前版本 Download - + 下載 Install Update - + 安裝更新 INSTALL - + 安裝 Target Branch - + 目標分支 SELECT - + 選取 Select a branch - + 選取一個分支 @@ -1174,12 +1174,12 @@ location set Experimental openpilot longitudinal control - + 使用 openpilot 縱向控制（實驗） <b>WARNING: openpilot longitudinal control is experimental for this car and will disable AEB.</b> - + <b>注意：這台車的 openpilot 縱向控制仍然是實驗中的功能，開啟這功能將會關閉自動緊急煞車 (AEB)。</b> From 64c2d4b30f7d4be1e1726a5668c548ecf8d6e32e Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 15 Sep 2022 19:37:12 -0700 Subject: [PATCH 05/13] Wrap new UI strings --- selfdrive/ui/qt/offroad/settings.cc | 4 ++-- selfdrive/ui/translations/main_ja.ts | 12 +++++++++++- selfdrive/ui/translations/main_ko.ts | 12 +++++++++++- selfdrive/ui/translations/main_pt-BR.ts | 12 +++++++++++- selfdrive/ui/translations/main_zh-CHS.ts | 12 +++++++++++- selfdrive/ui/translations/main_zh-CHT.ts | 12 +++++++++++- 6 files changed, 57 insertions(+), 7 deletions(-) diff --git a/selfdrive/ui/qt/offroad/settings.cc b/selfdrive/ui/qt/offroad/settings.cc index 52df247a25..ae878c5419 100644 --- a/selfdrive/ui/qt/offroad/settings.cc +++ b/selfdrive/ui/qt/offroad/settings.cc @@ -134,8 +134,8 @@ void TogglesPanel::updateToggles() { e2e_toggle->setEnabled(false); params.remove("EndToEndLong"); - const QString no_long = "openpilot longitudinal control is not currently available for this car."; - const QString exp_long = "Enable experimental longitudinal control to enable this."; + const QString no_long = tr("openpilot longitudinal control is not currently available for this car."); + const QString exp_long = tr("Enable experimental longitudinal control to enable this."); e2e_toggle->setDescription("" + (CP.getExperimentalLongitudinalAvailable() ? exp_long : no_long) + "

" + e2e_description); } diff --git a/selfdrive/ui/translations/main_ja.ts b/selfdrive/ui/translations/main_ja.ts index 4262473fb2..3cc9149755 100644 --- a/selfdrive/ui/translations/main_ja.ts +++ b/selfdrive/ui/translations/main_ja.ts @@ -1187,7 +1187,17 @@ location set アクセルとブレーキの制御をopenpilotに任せます。openpilotが人間と同じように運転します。最初期の実験段階です。 - + + openpilot longitudinal control is not currently available for this car. + + + + + Enable experimental longitudinal control to enable this. + + + + Disengage On Accelerator Pedal ｱｸｾﾙ踏むと openpilot をｷｬﾝｾﾙ diff --git a/selfdrive/ui/translations/main_ko.ts b/selfdrive/ui/translations/main_ko.ts index 2a827ca4a6..17914f21d8 100644 --- a/selfdrive/ui/translations/main_ko.ts +++ b/selfdrive/ui/translations/main_ko.ts @@ -1187,7 +1187,17 @@ location set 주행모델이 가속과 감속을 제어하도록 하면 openpilot은 운전자가 생각하는것처럼 운전합니다. (매우 실험적) - + + openpilot longitudinal control is not currently available for this car. + + + + + Enable experimental longitudinal control to enable this. + + + + Disengage On Accelerator Pedal 가속페달 조작시 해제 diff --git a/selfdrive/ui/translations/main_pt-BR.ts b/selfdrive/ui/translations/main_pt-BR.ts index 91ffabc625..fe028e18b5 100644 --- a/selfdrive/ui/translations/main_pt-BR.ts +++ b/selfdrive/ui/translations/main_pt-BR.ts @@ -1191,7 +1191,17 @@ trabalho definido - + + openpilot longitudinal control is not currently available for this car. + + + + + Enable experimental longitudinal control to enable this. + + + + Disengage On Accelerator Pedal Desacionar Com Pedal Do Acelerador diff --git a/selfdrive/ui/translations/main_zh-CHS.ts b/selfdrive/ui/translations/main_zh-CHS.ts index 8a6f856be7..28008ef06f 100644 --- a/selfdrive/ui/translations/main_zh-CHS.ts +++ b/selfdrive/ui/translations/main_zh-CHS.ts @@ -1185,7 +1185,17 @@ location set 让驾驶模型直接控制油门和刹车，openpilot将会模仿人类司机的驾驶方式。该功能仍非常实验性。 - + + openpilot longitudinal control is not currently available for this car. + + + + + Enable experimental longitudinal control to enable this. + + + + Disengage On Accelerator Pedal 踩油门时取消控制 diff --git a/selfdrive/ui/translations/main_zh-CHT.ts b/selfdrive/ui/translations/main_zh-CHT.ts index ef958e7140..19f5bf7392 100644 --- a/selfdrive/ui/translations/main_zh-CHT.ts +++ b/selfdrive/ui/translations/main_zh-CHT.ts @@ -1187,7 +1187,17 @@ location set 讓駕駛模型直接控製油門和剎車，openpilot將會模仿人類司機的駕駛方式。該功能仍非常實驗性。 - + + openpilot longitudinal control is not currently available for this car. + + + + + Enable experimental longitudinal control to enable this. + + + + Disengage On Accelerator Pedal 油門取消控車 From cfaa1b7d3eeeb8ae16b77e04a0416dbacf4bc6d2 Mon Sep 17 00:00:00 2001 From: Jason Shuler Date: Thu, 15 Sep 2022 23:11:53 -0400 Subject: [PATCH 06/13] GM: Chevy Bolt EV 2022-23 (#25430) * Chevy Bolt EV w ACC Port * dashcam * The website allows you to select the package without ACC * fix Bolt E(U)V centerToFront * Update selfdrive/car/gm/values.py Co-authored-by: Shane Smiskol --- selfdrive/car/gm/interface.py | 10 +++++----- selfdrive/car/gm/values.py | 6 ++++-- selfdrive/car/tests/routes.py | 1 + selfdrive/car/torque_data/override.yaml | 1 + 4 files changed, 11 insertions(+), 7 deletions(-) diff --git a/selfdrive/car/gm/interface.py b/selfdrive/car/gm/interface.py index f3ab1ee726..93be57cf21 100755 --- a/selfdrive/car/gm/interface.py +++ b/selfdrive/car/gm/interface.py @@ -71,7 +71,7 @@ class CarInterface(CarInterfaceBase): # These cars have been put into dashcam only due to both a lack of users and test coverage. # These cars likely still work fine. Once a user confirms each car works and a test route is # added to selfdrive/car/tests/routes.py, we can remove it from this list. - ret.dashcamOnly = candidate in {CAR.CADILLAC_ATS, CAR.HOLDEN_ASTRA, CAR.MALIBU, CAR.BUICK_REGAL, CAR.EQUINOX} + ret.dashcamOnly = candidate in {CAR.CADILLAC_ATS, CAR.HOLDEN_ASTRA, CAR.MALIBU, CAR.BUICK_REGAL, CAR.EQUINOX, CAR.BOLT_EV} # Start with a baseline tuning for all GM vehicles. Override tuning as needed in each model section below. ret.minSteerSpeed = 10 * CV.KPH_TO_MS @@ -138,23 +138,23 @@ class CarInterface(CarInterfaceBase): ret.mass = 1601. + STD_CARGO_KG ret.wheelbase = 2.78 ret.steerRatio = 15.3 - ret.centerToFront = ret.wheelbase * 0.49 + ret.centerToFront = ret.wheelbase * 0.5 elif candidate == CAR.ESCALADE_ESV: ret.minEnableSpeed = -1. # engage speed is decided by pcm ret.mass = 2739. + STD_CARGO_KG ret.wheelbase = 3.302 ret.steerRatio = 17.3 - ret.centerToFront = ret.wheelbase * 0.49 + ret.centerToFront = ret.wheelbase * 0.5 ret.lateralTuning.pid.kiBP, ret.lateralTuning.pid.kpBP = [[10., 41.0], [10., 41.0]] ret.lateralTuning.pid.kpV, ret.lateralTuning.pid.kiV = [[0.13, 0.24], [0.01, 0.02]] ret.lateralTuning.pid.kf = 0.000045 tire_stiffness_factor = 1.0 - elif candidate == CAR.BOLT_EUV: + elif candidate in (CAR.BOLT_EV, CAR.BOLT_EUV): ret.minEnableSpeed = -1 ret.mass = 1669. + STD_CARGO_KG - ret.wheelbase = 2.675 + ret.wheelbase = 2.63779 ret.steerRatio = 16.8 ret.centerToFront = 2.15 # measured tire_stiffness_factor = 1.0 diff --git a/selfdrive/car/gm/values.py b/selfdrive/car/gm/values.py index 25e624da7b..943e8a6585 100644 --- a/selfdrive/car/gm/values.py +++ b/selfdrive/car/gm/values.py @@ -58,6 +58,7 @@ class CAR: ACADIA = "GMC ACADIA DENALI 2018" BUICK_REGAL = "BUICK REGAL ESSENCE 2018" ESCALADE_ESV = "CADILLAC ESCALADE ESV 2016" + BOLT_EV = "CHEVROLET BOLT EV 2022" BOLT_EUV = "CHEVROLET BOLT EUV 2022" SILVERADO = "CHEVROLET SILVERADO 1500 2020" EQUINOX = "CHEVROLET EQUINOX 2019" @@ -85,6 +86,7 @@ CAR_INFO: Dict[str, Union[GMCarInfo, List[GMCarInfo]]] = { CAR.ACADIA: GMCarInfo("GMC Acadia 2018", video_link="https://www.youtube.com/watch?v=0ZN6DdsBUZo"), CAR.BUICK_REGAL: GMCarInfo("Buick Regal Essence 2018"), CAR.ESCALADE_ESV: GMCarInfo("Cadillac Escalade ESV 2016", "Adaptive Cruise Control (ACC) & LKAS"), + CAR.BOLT_EV: GMCarInfo("Chevrolet Bolt EV 2022-23", "Adaptive Cruise Control (ACC)", footnotes=[], harness=Harness.gm), CAR.BOLT_EUV: GMCarInfo("Chevrolet Bolt EUV 2022-23", "Premier or Premier Redline Trim without Super Cruise Package", video_link="https://youtu.be/xvwzGMUA210", footnotes=[], harness=Harness.gm), CAR.SILVERADO: [ GMCarInfo("Chevrolet Silverado 1500 2020-21", "Safety Package II", footnotes=[], harness=Harness.gm), @@ -176,9 +178,9 @@ FINGERPRINTS = { DBC: Dict[str, Dict[str, str]] = defaultdict(lambda: dbc_dict('gm_global_a_powertrain_generated', 'gm_global_a_object', chassis_dbc='gm_global_a_chassis')) -EV_CAR = {CAR.VOLT, CAR.BOLT_EUV} +EV_CAR = {CAR.VOLT, CAR.BOLT_EV, CAR.BOLT_EUV} # We're integrated at the camera with VOACC on these cars (instead of ASCM w/ OBD-II harness) -CAMERA_ACC_CAR = {CAR.BOLT_EUV, CAR.SILVERADO, CAR.EQUINOX} +CAMERA_ACC_CAR = {CAR.BOLT_EV, CAR.BOLT_EUV, CAR.SILVERADO, CAR.EQUINOX} STEER_THRESHOLD = 1.0 diff --git a/selfdrive/car/tests/routes.py b/selfdrive/car/tests/routes.py index 9f28bf8543..e86525baac 100644 --- a/selfdrive/car/tests/routes.py +++ b/selfdrive/car/tests/routes.py @@ -22,6 +22,7 @@ non_tested_cars = [ GM.HOLDEN_ASTRA, GM.MALIBU, GM.EQUINOX, + GM.BOLT_EV, HYUNDAI.ELANTRA_GT_I30, HYUNDAI.GENESIS_G90, HYUNDAI.KIA_OPTIMA_H, diff --git a/selfdrive/car/torque_data/override.yaml b/selfdrive/car/torque_data/override.yaml index 2e0f601e84..b5d1a31193 100644 --- a/selfdrive/car/torque_data/override.yaml +++ b/selfdrive/car/torque_data/override.yaml @@ -25,6 +25,7 @@ KIA EV6 2022: [3.5, 3.0, 0.0] RAM 1500 5TH GEN: [2.0, 2.0, 0.0] RAM HD 5TH GEN: [1.4, 1.4, 0.0] SUBARU OUTBACK 6TH GEN: [2.3, 2.3, 0.11] +CHEVROLET BOLT EV 2022: [2.0, 2.0, 0.05] CHEVROLET BOLT EUV 2022: [2.0, 2.0, 0.05] CHEVROLET SILVERADO 1500 2020: [1.9, 1.9, 0.112] CHEVROLET EQUINOX 2019: [2.0, 2.0, 0.05] From b133a4c9a8e8f3ab8211fe1e7a52bd0bb41c5c47 Mon Sep 17 00:00:00 2001 From: Vivek Aithal Date: Thu, 15 Sep 2022 20:15:57 -0700 Subject: [PATCH 07/13] regenerate replay segments for torqued (#25805) * update segments in test_processes * bump cereal * update refs --- cereal | 2 +- selfdrive/test/process_replay/ref_commit | 2 +- .../test/process_replay/test_processes.py | 30 +++++++++---------- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/cereal b/cereal index 513dfc7ee0..e4130c9055 160000 --- a/cereal +++ b/cereal @@ -1 +1 @@ -Subproject commit 513dfc7ee001243cd68a57a9d92fe3170fc49c7d +Subproject commit e4130c90558dfb491e132992dce36e0e620e070a diff --git a/selfdrive/test/process_replay/ref_commit b/selfdrive/test/process_replay/ref_commit index 7390610252..062611316c 100644 --- a/selfdrive/test/process_replay/ref_commit +++ b/selfdrive/test/process_replay/ref_commit @@ -1 +1 @@ -ef5395e5f36550d2b485216eee5406bf6062e9c9 \ No newline at end of file +147410f09f242f05b922c9cc7ac04c3c3366419c \ No newline at end of file diff --git a/selfdrive/test/process_replay/test_processes.py b/selfdrive/test/process_replay/test_processes.py index e8c2e1dc94..0f118971c6 100755 --- a/selfdrive/test/process_replay/test_processes.py +++ b/selfdrive/test/process_replay/test_processes.py @@ -38,21 +38,21 @@ original_segments = [ ] segments = [ - ("BODY", "regen660D86654BA|2022-07-06--14-27-15--0"), - ("HYUNDAI", "regen114E5FF24D8|2022-07-14--17-08-47--0"), - ("HYUNDAI", "d824e27e8c60172c|2022-08-19--17-58-07--2"), - ("TOYOTA", "regenBA97410FBEC|2022-07-06--14-26-49--0"), - ("TOYOTA2", "regenDEDB1D9C991|2022-07-06--14-54-08--0"), - ("TOYOTA3", "regenDDC1FE60734|2022-07-06--14-32-06--0"), - ("HONDA", "regenE62960EEC38|2022-07-14--19-33-24--0"), - ("HONDA2", "regenC3EBD92F029|2022-07-14--19-29-47--0"), - ("CHRYSLER", "regen38346FB33D0|2022-07-14--18-05-26--0"), - ("RAM", "2f4452b03ccb98f0|2022-07-07--08-01-56--3"), - ("SUBARU", "regen54A1E2BE5AA|2022-07-14--18-07-50--0"), - ("GM", "regen76027B408B7|2022-08-16--19-56-58--0"), - ("NISSAN", "regenCA0B0DC946E|2022-07-14--18-10-17--0"), - ("VOLKSWAGEN", "regen007098CA0EF|2022-07-06--15-01-26--0"), - ("MAZDA", "regen61BA413D53B|2022-07-06--14-39-42--0"), + ("BODY", "regen9D38397D30D|2022-09-09--13-12-48--0"), + ("HYUNDAI", "regenB3953B393C0|2022-09-09--14-49-37--0"), + ("HYUNDAI", "regen8DB830E5376|2022-09-13--17-24-37--0"), + ("TOYOTA", "regen8FCBB6F06F1|2022-09-09--13-14-07--0"), + ("TOYOTA2", "regen956BFA75300|2022-09-09--14-51-24--0"), + ("TOYOTA3", "regenE909BC2F430|2022-09-09--20-44-49--0"), + ("HONDA", "regenD1D10209015|2022-09-09--14-53-09--0"), + ("HONDA2", "regen3F7C2EFDC08|2022-09-09--19-41-19--0"), + ("CHRYSLER", "regen92783EAE66B|2022-09-09--13-15-44--0"), + ("RAM", "regenBE5DAAEF30F|2022-09-13--17-06-24--0"), + ("SUBARU", "regen8A363AF7E14|2022-09-13--17-20-39--0"), + ("GM", "regen31EA3F9A37C|2022-09-09--21-06-36--0"), + ("NISSAN", "regenAA21ADE5921|2022-09-09--19-44-37--0"), + ("VOLKSWAGEN", "regenA1BF4D17761|2022-09-09--19-46-24--0"), + ("MAZDA", "regen1994C97E977|2022-09-13--16-34-44--0"), ] # dashcamOnly makes don't need to be tested until a full port is done From b7d9f157faa33023ab07db561c155db0abb28c0b Mon Sep 17 00:00:00 2001 From: Jason Wen <47793918+sunnyhaibin@users.noreply.github.com> Date: Thu, 15 Sep 2022 23:16:54 -0400 Subject: [PATCH 08/13] Updater: Reboot instead of shutdown to install new branch (#25804) Reboot instead of shutdown to install new branch --- selfdrive/ui/qt/offroad/software_settings.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/selfdrive/ui/qt/offroad/software_settings.cc b/selfdrive/ui/qt/offroad/software_settings.cc index c9deef2ec4..4f048241c3 100644 --- a/selfdrive/ui/qt/offroad/software_settings.cc +++ b/selfdrive/ui/qt/offroad/software_settings.cc @@ -45,7 +45,7 @@ SoftwarePanel::SoftwarePanel(QWidget* parent) : ListWidget(parent) { installBtn = new ButtonControl(tr("Install Update"), tr("INSTALL")); connect(installBtn, &ButtonControl::clicked, [=]() { installBtn->setEnabled(false); - params.putBool("DoShutdown", true); + params.putBool("DoReboot", true); }); addItem(installBtn); From f0665911b2aa5807348ee5bf209ee21b8be2ca89 Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Fri, 16 Sep 2022 11:36:13 +0800 Subject: [PATCH 09/13] map: fix repeated call to m_map->setZoom (#25784) Fix repeated map api calls --- selfdrive/ui/qt/maps/map.cc | 3 ++- selfdrive/ui/qt/maps/map.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/selfdrive/ui/qt/maps/map.cc b/selfdrive/ui/qt/maps/map.cc index 71706fd35e..b5519daccf 100644 --- a/selfdrive/ui/qt/maps/map.cc +++ b/selfdrive/ui/qt/maps/map.cc @@ -204,7 +204,8 @@ void MapWindow::updateState(const UIState &s) { if (zoom_counter == 0) { m_map->setZoom(util::map_val(velocity_filter.x(), 0, 30, MAX_ZOOM, MIN_ZOOM)); - } else { + zoom_counter = -1; + } else if (zoom_counter > 0) { zoom_counter--; } diff --git a/selfdrive/ui/qt/maps/map.h b/selfdrive/ui/qt/maps/map.h index ecba867edb..c3d5e92530 100644 --- a/selfdrive/ui/qt/maps/map.h +++ b/selfdrive/ui/qt/maps/map.h @@ -98,7 +98,7 @@ private: // Panning QPointF m_lastPos; int pan_counter = 0; - int zoom_counter = 0; + int zoom_counter = -1; // Position std::optional last_position; From 8fcbcd800610f30ddf85b5a314dbf40afb0fa320 Mon Sep 17 00:00:00 2001 From: eFini Date: Fri, 16 Sep 2022 11:38:53 +0800 Subject: [PATCH 10/13] Multilang: add missing Chinese (Traditional) translations (#25807) added missing cht translations --- selfdrive/ui/translations/main_zh-CHT.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/selfdrive/ui/translations/main_zh-CHT.ts b/selfdrive/ui/translations/main_zh-CHT.ts index 19f5bf7392..364508bd1c 100644 --- a/selfdrive/ui/translations/main_zh-CHT.ts +++ b/selfdrive/ui/translations/main_zh-CHT.ts @@ -1189,12 +1189,12 @@ location set openpilot longitudinal control is not currently available for this car. - + openpilot 縱向控制目前不適用於這輛車。 Enable experimental longitudinal control to enable this. - + 打開縱向控制（實驗）以啟用此功能。 From 5356216e92f7c46d5aaefa1c3e85c91fd17816e4 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 15 Sep 2022 20:45:01 -0700 Subject: [PATCH 11/13] remove unused compute_gb (#25808) --- selfdrive/car/mazda/interface.py | 4 ---- selfdrive/car/mock/interface.py | 4 ---- 2 files changed, 8 deletions(-) diff --git a/selfdrive/car/mazda/interface.py b/selfdrive/car/mazda/interface.py index 89ed5638cb..7c42431e33 100755 --- a/selfdrive/car/mazda/interface.py +++ b/selfdrive/car/mazda/interface.py @@ -10,10 +10,6 @@ EventName = car.CarEvent.EventName class CarInterface(CarInterfaceBase): - @staticmethod - def compute_gb(accel, speed): - return float(accel) / 4.0 - @staticmethod def get_params(candidate, fingerprint=gen_empty_fingerprint(), car_fw=None, experimental_long=False): ret = CarInterfaceBase.get_std_params(candidate, fingerprint) diff --git a/selfdrive/car/mock/interface.py b/selfdrive/car/mock/interface.py index 2c7f4611ee..77e3703c2d 100755 --- a/selfdrive/car/mock/interface.py +++ b/selfdrive/car/mock/interface.py @@ -28,10 +28,6 @@ class CarInterface(CarInterfaceBase): self.yaw_rate = 0. self.yaw_rate_meas = 0. - @staticmethod - def compute_gb(accel, speed): - return accel - @staticmethod def get_params(candidate, fingerprint=gen_empty_fingerprint(), car_fw=None, experimental_long=False): ret = CarInterfaceBase.get_std_params(candidate, fingerprint) From b7dc1968cd4c61d33f96124b36d8d7a48957748f Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 15 Sep 2022 21:21:10 -0700 Subject: [PATCH 12/13] GM minSteerSpeed: add some tolerance for Volt (#25809) * add some tolerance for volts * add comment * update refs --- selfdrive/car/gm/interface.py | 3 ++- selfdrive/test/process_replay/ref_commit | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/selfdrive/car/gm/interface.py b/selfdrive/car/gm/interface.py index 93be57cf21..22ea83759a 100755 --- a/selfdrive/car/gm/interface.py +++ b/selfdrive/car/gm/interface.py @@ -74,7 +74,8 @@ class CarInterface(CarInterfaceBase): ret.dashcamOnly = candidate in {CAR.CADILLAC_ATS, CAR.HOLDEN_ASTRA, CAR.MALIBU, CAR.BUICK_REGAL, CAR.EQUINOX, CAR.BOLT_EV} # Start with a baseline tuning for all GM vehicles. Override tuning as needed in each model section below. - ret.minSteerSpeed = 10 * CV.KPH_TO_MS + # Some GMs need some tolerance above 10 kph to avoid a fault + ret.minSteerSpeed = 10.1 * CV.KPH_TO_MS ret.lateralTuning.pid.kiBP, ret.lateralTuning.pid.kpBP = [[0.], [0.]] ret.lateralTuning.pid.kpV, ret.lateralTuning.pid.kiV = [[0.2], [0.00]] ret.lateralTuning.pid.kf = 0.00004 # full torque for 20 deg at 80mph means 0.00007818594 diff --git a/selfdrive/test/process_replay/ref_commit b/selfdrive/test/process_replay/ref_commit index 062611316c..b1a2785ba3 100644 --- a/selfdrive/test/process_replay/ref_commit +++ b/selfdrive/test/process_replay/ref_commit @@ -1 +1 @@ -147410f09f242f05b922c9cc7ac04c3c3366419c \ No newline at end of file +a4aa1f37c6d966151d3b43a0b51fffbcfa0187b1 \ No newline at end of file From 40f89b183e5ab39d4a176e54268b0eb9de8e9ebc Mon Sep 17 00:00:00 2001 From: ambientocclusion <1399123+ambientocclusion@users.noreply.github.com> Date: Thu, 15 Sep 2022 21:59:52 -0700 Subject: [PATCH 13/13] Multilang: add missing Japanese translations (#25803) Add missing Japanese translations --- selfdrive/ui/translations/main_ja.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/selfdrive/ui/translations/main_ja.ts b/selfdrive/ui/translations/main_ja.ts index 3cc9149755..b41e1bff77 100644 --- a/selfdrive/ui/translations/main_ja.ts +++ b/selfdrive/ui/translations/main_ja.ts @@ -985,42 +985,42 @@ location set Updates are only downloaded while the car is off. - + 車の電源がオフの間のみ、アップデートのダウンロードが行われます。 Current Version - + 現在のバージョン Download - + ダウンロード Install Update - + アップデート INSTALL - + インストール Target Branch - + 対象のブランチ SELECT - + 選択 Select a branch - + ブランチを選択 @@ -1189,12 +1189,12 @@ location set openpilot longitudinal control is not currently available for this car. - + openpilotによるアクセル制御は、この車では現在利用できません。 Enable experimental longitudinal control to enable this. - + ここ機能を使う為には、「実験段階のopenpilotによるアクセル制御」を先に有効化してください。