diff --git a/selfdrive/car/chrysler/interface.py b/selfdrive/car/chrysler/interface.py index d0f4ace97f..4d7dab3ede 100755 --- a/selfdrive/car/chrysler/interface.py +++ b/selfdrive/car/chrysler/interface.py @@ -12,9 +12,6 @@ class CarInterface(CarInterfaceBase): ret.carName = "chrysler" ret.safetyModel = car.CarParams.SafetyModel.chrysler - # Chrysler port is a community feature, since we don't own one to test - ret.communityFeature = True - # Speed conversion: 20, 45 mph ret.wheelbase = 3.089 # in meters for Pacifica Hybrid 2017 ret.steerRatio = 16.2 # Pacifica Hybrid 2017 diff --git a/selfdrive/car/gm/interface.py b/selfdrive/car/gm/interface.py index c4a702be77..94e950106c 100755 --- a/selfdrive/car/gm/interface.py +++ b/selfdrive/car/gm/interface.py @@ -22,10 +22,6 @@ class CarInterface(CarInterfaceBase): ret.safetyModel = car.CarParams.SafetyModel.gm ret.pcmCruise = False # stock cruise control is kept off - # GM port is a community feature - # TODO: make a port that uses a car harness and it only intercepts the camera - ret.communityFeature = True - # Presence of a camera on the object bus is ok. # Have to go to read_only if ASCM is online (ACC-enabled cars), # or camera is on powertrain bus (LKA cars without ACC). diff --git a/selfdrive/car/honda/interface.py b/selfdrive/car/honda/interface.py index 29f259f325..79c7853e95 100755 --- a/selfdrive/car/honda/interface.py +++ b/selfdrive/car/honda/interface.py @@ -41,7 +41,6 @@ class CarInterface(CarInterfaceBase): ret.openpilotLongitudinalControl = Params().get_bool("DisableRadar") ret.pcmCruise = not ret.openpilotLongitudinalControl - ret.communityFeature = ret.openpilotLongitudinalControl else: ret.safetyModel = car.CarParams.SafetyModel.hondaNidec ret.enableGasInterceptor = 0x201 in fingerprint[0] diff --git a/selfdrive/car/hyundai/interface.py b/selfdrive/car/hyundai/interface.py index 7e27db9b76..6d8ceccf96 100644 --- a/selfdrive/car/hyundai/interface.py +++ b/selfdrive/car/hyundai/interface.py @@ -28,8 +28,6 @@ class CarInterface(CarInterfaceBase): ret.openpilotLongitudinalControl = Params().get_bool("DisableRadar") and candidate in [CAR.SONATA, CAR.SONATA_HYBRID, CAR.PALISADE, CAR.SANTA_FE] ret.safetyParam = 0 - # Most Hyundai car ports are community features for now - ret.communityFeature = candidate not in [CAR.SONATA, CAR.PALISADE] or ret.openpilotLongitudinalControl ret.pcmCruise = not ret.openpilotLongitudinalControl ret.steerActuatorDelay = 0.1 # Default delay diff --git a/selfdrive/car/mazda/interface.py b/selfdrive/car/mazda/interface.py index dfc1c12bfc..bf199a4429 100755 --- a/selfdrive/car/mazda/interface.py +++ b/selfdrive/car/mazda/interface.py @@ -22,7 +22,6 @@ class CarInterface(CarInterfaceBase): ret.safetyModel = car.CarParams.SafetyModel.mazda ret.radarOffCan = True - ret.communityFeature = True ret.dashcamOnly = True ret.steerActuatorDelay = 0.1 diff --git a/selfdrive/car/nissan/interface.py b/selfdrive/car/nissan/interface.py index 3edcbd0f8c..ca97e83c96 100644 --- a/selfdrive/car/nissan/interface.py +++ b/selfdrive/car/nissan/interface.py @@ -16,9 +16,6 @@ class CarInterface(CarInterfaceBase): ret.carName = "nissan" ret.safetyModel = car.CarParams.SafetyModel.nissan - # Nissan port is a community feature, since we don't own one to test - ret.communityFeature = True - ret.steerLimitAlert = False ret.steerRateCost = 0.5 diff --git a/selfdrive/car/subaru/interface.py b/selfdrive/car/subaru/interface.py index 260933cb25..b907b03e5b 100644 --- a/selfdrive/car/subaru/interface.py +++ b/selfdrive/car/subaru/interface.py @@ -20,8 +20,6 @@ class CarInterface(CarInterfaceBase): ret.safetyModel = car.CarParams.SafetyModel.subaru ret.enableBsm = 0x228 in fingerprint[0] - # Subaru port is a community feature, since we don't own one to test - ret.communityFeature = True ret.dashcamOnly = candidate in PREGLOBAL_CARS ret.steerRateCost = 0.7 diff --git a/selfdrive/car/tesla/interface.py b/selfdrive/car/tesla/interface.py index 2078fa38b4..72a751ac2d 100755 --- a/selfdrive/car/tesla/interface.py +++ b/selfdrive/car/tesla/interface.py @@ -19,7 +19,6 @@ class CarInterface(CarInterfaceBase): ret.steerControlType = car.CarParams.SteerControlType.angle ret.openpilotLongitudinalControl = False - ret.communityFeature = True ret.steerActuatorDelay = 0.1 ret.steerRateCost = 0.5 diff --git a/selfdrive/car/volkswagen/interface.py b/selfdrive/car/volkswagen/interface.py index ccdfeea14c..6bc07e6352 100644 --- a/selfdrive/car/volkswagen/interface.py +++ b/selfdrive/car/volkswagen/interface.py @@ -24,7 +24,6 @@ class CarInterface(CarInterfaceBase): def get_params(candidate, fingerprint=gen_empty_fingerprint(), car_fw=None): ret = CarInterfaceBase.get_std_params(candidate, fingerprint) ret.carName = "volkswagen" - ret.communityFeature = True ret.radarOffCan = True if True: # pylint: disable=using-constant-test diff --git a/selfdrive/controls/tests/test_startup.py b/selfdrive/controls/tests/test_startup.py index b35aa106d8..b53f960dde 100755 --- a/selfdrive/controls/tests/test_startup.py +++ b/selfdrive/controls/tests/test_startup.py @@ -8,7 +8,6 @@ import cereal.messaging as messaging from common.params import Params from selfdrive.boardd.boardd_api_impl import can_list_to_can_capnp # pylint: disable=no-name-in-module,import-error from selfdrive.car.fingerprints import _FINGERPRINTS -from selfdrive.car.hyundai.values import CAR as HYUNDAI from selfdrive.car.toyota.values import CAR as TOYOTA from selfdrive.car.mazda.values import CAR as MAZDA from selfdrive.controls.lib.events import EVENT_NAME @@ -50,10 +49,6 @@ class TestStartup(unittest.TestCase): (EventName.startupMaster, TOYOTA.COROLLA, True, COROLLA_FW_VERSIONS_NO_DSU), (EventName.communityFeatureDisallowed, TOYOTA.COROLLA, False, COROLLA_FW_VERSIONS_NO_DSU), - # community supported car - (EventName.startupMaster, HYUNDAI.KIA_STINGER, True, None), - (EventName.communityFeatureDisallowed, HYUNDAI.KIA_STINGER, False, None), - # dashcamOnly car (EventName.startupNoControl, MAZDA.CX5, True, CX5_FW_VERSIONS), (EventName.startupNoControl, MAZDA.CX5, False, CX5_FW_VERSIONS), diff --git a/selfdrive/test/process_replay/ref_commit b/selfdrive/test/process_replay/ref_commit index 6041ee2cd4..01db9dc94e 100644 --- a/selfdrive/test/process_replay/ref_commit +++ b/selfdrive/test/process_replay/ref_commit @@ -1 +1 @@ -3a9687d9daaaf869a37edb7e640ad3e2d3588fcb \ No newline at end of file +94ef06857155a3f5ed38999182178e4e3a11f9d5 \ No newline at end of file diff --git a/selfdrive/ui/qt/offroad/settings.cc b/selfdrive/ui/qt/offroad/settings.cc index b64c6526ed..5320644986 100644 --- a/selfdrive/ui/qt/offroad/settings.cc +++ b/selfdrive/ui/qt/offroad/settings.cc @@ -49,7 +49,7 @@ TogglesPanel::TogglesPanel(QWidget *parent) : ListWidget(parent) { this)); addItem(new ParamControl("CommunityFeaturesToggle", "Enable Community Features", - "Use features from the open source community that are not maintained or supported by comma.ai and have not been confirmed to meet the standard safety model. These features include community supported cars and community supported hardware. Be extra cautious when using these features", + "Use features, such as community supported hardware, from the open source community that are not maintained or supported by comma.ai and have not been confirmed to meet the standard safety model. Be extra cautious when using these features", "../assets/offroad/icon_shell.png", this));