From 4bb5986c14aa66516524330201c48980b36de558 Mon Sep 17 00:00:00 2001 From: Maxime Desroches Date: Fri, 8 Aug 2025 19:57:20 -0700 Subject: [PATCH 1/2] setup: fix url for urllib (#35958) fix --- system/ui/setup.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/system/ui/setup.py b/system/ui/setup.py index 8ff6b67000..d675e868ff 100755 --- a/system/ui/setup.py +++ b/system/ui/setup.py @@ -4,6 +4,7 @@ import re import threading import time import urllib.request +from urllib.parse import urlparse from enum import IntEnum import pyray as rl @@ -303,7 +304,9 @@ class Setup(Widget): if re.match("^([^/.]+)/([^/]+)$", url): url = f"https://installer.comma.ai/{url}" - self.download_url = url + parsed = urlparse(url, scheme='https') + self.download_url = (urlparse(f"https://{url}") if not parsed.netloc else parsed).geturl() + self.state = SetupState.DOWNLOADING self.download_thread = threading.Thread(target=self._download_thread, daemon=True) From 83f6843a4803b3c66cd0e9bbd55e6bc0e4d0b1ac Mon Sep 17 00:00:00 2001 From: Maxime Desroches Date: Fri, 8 Aug 2025 20:07:33 -0700 Subject: [PATCH 2/2] ci: run all unit tests (#35959) * more please * back --- .github/workflows/selfdrive_tests.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/selfdrive_tests.yaml b/.github/workflows/selfdrive_tests.yaml index c4dfebd997..fb082ae407 100644 --- a/.github/workflows/selfdrive_tests.yaml +++ b/.github/workflows/selfdrive_tests.yaml @@ -163,7 +163,7 @@ jobs: run: | ${{ env.RUN }} "source selfdrive/test/setup_xvfb.sh && \ $PYTEST --collect-only -m 'not slow' &> /dev/null && \ - PYTHONTRACEMALLOC=1 MAX_EXAMPLES=1 $PYTEST -m 'not slow' -k test_raylib_ui && \ + MAX_EXAMPLES=1 $PYTEST -m 'not slow' && \ ./selfdrive/ui/tests/create_test_translations.sh && \ QT_QPA_PLATFORM=offscreen ./selfdrive/ui/tests/test_translations && \ chmod -R 777 /tmp/comma_download_cache"