From 768f36979ab042b6f04c48da5d9913d7a78c9a13 Mon Sep 17 00:00:00 2001
From: Shane Smiskol <shane@smiskol.com>
Date: Thu, 12 May 2022 14:55:43 -0700
Subject: [PATCH] process replay CI: print diff after test (#24513)

* make sure we print the diff before updating refs

* cause fail

* when only uploading no need to print success status or update diff

don't print succeed/fail when only uploading

* Revert "cause fail"

This reverts commit 6e5db1a0ac6ccd0e6a0885d72d79d75c610bdc1f.

* Revert "when only uploading no need to print success status or update diff"

This reverts commit d6727f30a109fd7330746005aa7b228c9eca3e79.
old-commit-hash: f918ab7967ba25d8fe21275fd03330046cfe94de
---
 .github/workflows/selfdrive_tests.yaml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/selfdrive_tests.yaml b/.github/workflows/selfdrive_tests.yaml
index feb7cfa1d5..98cdeab306 100644
--- a/.github/workflows/selfdrive_tests.yaml
+++ b/.github/workflows/selfdrive_tests.yaml
@@ -317,13 +317,6 @@ jobs:
         ${{ env.RUN }} "scons -j$(nproc) && \
                         FILEREADER_CACHE=1 CI=1 coverage run selfdrive/test/process_replay/test_processes.py && \
                         coverage xml"
-    - name: Upload reference logs
-      if: ${{ failure() && github.event_name == 'pull_request' && github.repository == 'commaai/openpilot' && env.AZURE_TOKEN != '' }}
-      run: |
-        ${{ env.RUN }} "scons -j$(nproc) && \
-                        CI=1 AZURE_TOKEN='$AZURE_TOKEN' python selfdrive/test/process_replay/test_processes.py --upload-only"
-    - name: "Upload coverage to Codecov"
-      uses: codecov/codecov-action@v2
     - name: Print diff
       if: always()
       run: cat selfdrive/test/process_replay/diff.txt
@@ -333,6 +326,13 @@ jobs:
       with:
         name: process_replay_diff.txt
         path: selfdrive/test/process_replay/diff.txt
+    - name: Upload reference logs
+      if: ${{ failure() && github.event_name == 'pull_request' && github.repository == 'commaai/openpilot' && env.AZURE_TOKEN != '' }}
+      run: |
+        ${{ env.RUN }} "scons -j$(nproc) && \
+                        CI=1 AZURE_TOKEN='$AZURE_TOKEN' python selfdrive/test/process_replay/test_processes.py --upload-only"
+    - name: "Upload coverage to Codecov"
+      uses: codecov/codecov-action@v2
 
   #model_replay:
   #  name: model replay