ui/map: check NavDestination only if navInstruction is invalid (#29331)

* check NavDestination only if navInstruction is invalid * Update selfdrive/ui/qt/maps/map.cc Co-authored-by: Shane Smiskol <shane@smiskol.com> --------- Co-authored-by: Shane Smiskol <shane@smiskol.com>
2 years ago · 80356b34f1
parent 15bb9dd096
commit 80356b34f1
1 changed files with 1 additions and 2 deletions
--- a/selfdrive/ui/qt/maps/map.cc
+++ b/selfdrive/ui/qt/maps/map.cc
@ -213,8 +213,7 @@ void MapWindow::updateState(const UIState &s) {
    // - API exception/no internet
    // - route response is empty
    // - any time navd is waiting for recompute_countdown
-    auto dest = coordinate_from_param("NavDestination");
-    routing_problem = !sm.valid("navInstruction") && dest.has_value();
+    routing_problem = !sm.valid("navInstruction") && coordinate_from_param("NavDestination").has_value();

    if (sm.valid("navInstruction")) {
      auto i = sm["navInstruction"].getNavInstruction();