remove community supported cars from community features (#22330)

* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
old-commit-hash: 649af76fd4
commatwo_master
Adeeb Shihadeh 4 years ago committed by GitHub
parent 06e22360ae
commit 821f1f6cb6
  1. 3
      selfdrive/car/chrysler/interface.py
  2. 4
      selfdrive/car/gm/interface.py
  3. 1
      selfdrive/car/honda/interface.py
  4. 2
      selfdrive/car/hyundai/interface.py
  5. 1
      selfdrive/car/mazda/interface.py
  6. 3
      selfdrive/car/nissan/interface.py
  7. 2
      selfdrive/car/subaru/interface.py
  8. 1
      selfdrive/car/tesla/interface.py
  9. 1
      selfdrive/car/volkswagen/interface.py
  10. 5
      selfdrive/controls/tests/test_startup.py
  11. 2
      selfdrive/test/process_replay/ref_commit
  12. 2
      selfdrive/ui/qt/offroad/settings.cc

@ -12,9 +12,6 @@ class CarInterface(CarInterfaceBase):
ret.carName = "chrysler" ret.carName = "chrysler"
ret.safetyModel = car.CarParams.SafetyModel.chrysler ret.safetyModel = car.CarParams.SafetyModel.chrysler
# Chrysler port is a community feature, since we don't own one to test
ret.communityFeature = True
# Speed conversion: 20, 45 mph # Speed conversion: 20, 45 mph
ret.wheelbase = 3.089 # in meters for Pacifica Hybrid 2017 ret.wheelbase = 3.089 # in meters for Pacifica Hybrid 2017
ret.steerRatio = 16.2 # Pacifica Hybrid 2017 ret.steerRatio = 16.2 # Pacifica Hybrid 2017

@ -22,10 +22,6 @@ class CarInterface(CarInterfaceBase):
ret.safetyModel = car.CarParams.SafetyModel.gm ret.safetyModel = car.CarParams.SafetyModel.gm
ret.pcmCruise = False # stock cruise control is kept off ret.pcmCruise = False # stock cruise control is kept off
# GM port is a community feature
# TODO: make a port that uses a car harness and it only intercepts the camera
ret.communityFeature = True
# Presence of a camera on the object bus is ok. # Presence of a camera on the object bus is ok.
# Have to go to read_only if ASCM is online (ACC-enabled cars), # Have to go to read_only if ASCM is online (ACC-enabled cars),
# or camera is on powertrain bus (LKA cars without ACC). # or camera is on powertrain bus (LKA cars without ACC).

@ -41,7 +41,6 @@ class CarInterface(CarInterfaceBase):
ret.openpilotLongitudinalControl = Params().get_bool("DisableRadar") ret.openpilotLongitudinalControl = Params().get_bool("DisableRadar")
ret.pcmCruise = not ret.openpilotLongitudinalControl ret.pcmCruise = not ret.openpilotLongitudinalControl
ret.communityFeature = ret.openpilotLongitudinalControl
else: else:
ret.safetyModel = car.CarParams.SafetyModel.hondaNidec ret.safetyModel = car.CarParams.SafetyModel.hondaNidec
ret.enableGasInterceptor = 0x201 in fingerprint[0] ret.enableGasInterceptor = 0x201 in fingerprint[0]

@ -28,8 +28,6 @@ class CarInterface(CarInterfaceBase):
ret.openpilotLongitudinalControl = Params().get_bool("DisableRadar") and candidate in [CAR.SONATA, CAR.SONATA_HYBRID, CAR.PALISADE, CAR.SANTA_FE] ret.openpilotLongitudinalControl = Params().get_bool("DisableRadar") and candidate in [CAR.SONATA, CAR.SONATA_HYBRID, CAR.PALISADE, CAR.SANTA_FE]
ret.safetyParam = 0 ret.safetyParam = 0
# Most Hyundai car ports are community features for now
ret.communityFeature = candidate not in [CAR.SONATA, CAR.PALISADE] or ret.openpilotLongitudinalControl
ret.pcmCruise = not ret.openpilotLongitudinalControl ret.pcmCruise = not ret.openpilotLongitudinalControl
ret.steerActuatorDelay = 0.1 # Default delay ret.steerActuatorDelay = 0.1 # Default delay

@ -22,7 +22,6 @@ class CarInterface(CarInterfaceBase):
ret.safetyModel = car.CarParams.SafetyModel.mazda ret.safetyModel = car.CarParams.SafetyModel.mazda
ret.radarOffCan = True ret.radarOffCan = True
ret.communityFeature = True
ret.dashcamOnly = True ret.dashcamOnly = True
ret.steerActuatorDelay = 0.1 ret.steerActuatorDelay = 0.1

@ -16,9 +16,6 @@ class CarInterface(CarInterfaceBase):
ret.carName = "nissan" ret.carName = "nissan"
ret.safetyModel = car.CarParams.SafetyModel.nissan ret.safetyModel = car.CarParams.SafetyModel.nissan
# Nissan port is a community feature, since we don't own one to test
ret.communityFeature = True
ret.steerLimitAlert = False ret.steerLimitAlert = False
ret.steerRateCost = 0.5 ret.steerRateCost = 0.5

@ -20,8 +20,6 @@ class CarInterface(CarInterfaceBase):
ret.safetyModel = car.CarParams.SafetyModel.subaru ret.safetyModel = car.CarParams.SafetyModel.subaru
ret.enableBsm = 0x228 in fingerprint[0] ret.enableBsm = 0x228 in fingerprint[0]
# Subaru port is a community feature, since we don't own one to test
ret.communityFeature = True
ret.dashcamOnly = candidate in PREGLOBAL_CARS ret.dashcamOnly = candidate in PREGLOBAL_CARS
ret.steerRateCost = 0.7 ret.steerRateCost = 0.7

@ -19,7 +19,6 @@ class CarInterface(CarInterfaceBase):
ret.steerControlType = car.CarParams.SteerControlType.angle ret.steerControlType = car.CarParams.SteerControlType.angle
ret.openpilotLongitudinalControl = False ret.openpilotLongitudinalControl = False
ret.communityFeature = True
ret.steerActuatorDelay = 0.1 ret.steerActuatorDelay = 0.1
ret.steerRateCost = 0.5 ret.steerRateCost = 0.5

@ -24,7 +24,6 @@ class CarInterface(CarInterfaceBase):
def get_params(candidate, fingerprint=gen_empty_fingerprint(), car_fw=None): def get_params(candidate, fingerprint=gen_empty_fingerprint(), car_fw=None):
ret = CarInterfaceBase.get_std_params(candidate, fingerprint) ret = CarInterfaceBase.get_std_params(candidate, fingerprint)
ret.carName = "volkswagen" ret.carName = "volkswagen"
ret.communityFeature = True
ret.radarOffCan = True ret.radarOffCan = True
if True: # pylint: disable=using-constant-test if True: # pylint: disable=using-constant-test

@ -8,7 +8,6 @@ import cereal.messaging as messaging
from common.params import Params from common.params import Params
from selfdrive.boardd.boardd_api_impl import can_list_to_can_capnp # pylint: disable=no-name-in-module,import-error from selfdrive.boardd.boardd_api_impl import can_list_to_can_capnp # pylint: disable=no-name-in-module,import-error
from selfdrive.car.fingerprints import _FINGERPRINTS from selfdrive.car.fingerprints import _FINGERPRINTS
from selfdrive.car.hyundai.values import CAR as HYUNDAI
from selfdrive.car.toyota.values import CAR as TOYOTA from selfdrive.car.toyota.values import CAR as TOYOTA
from selfdrive.car.mazda.values import CAR as MAZDA from selfdrive.car.mazda.values import CAR as MAZDA
from selfdrive.controls.lib.events import EVENT_NAME from selfdrive.controls.lib.events import EVENT_NAME
@ -50,10 +49,6 @@ class TestStartup(unittest.TestCase):
(EventName.startupMaster, TOYOTA.COROLLA, True, COROLLA_FW_VERSIONS_NO_DSU), (EventName.startupMaster, TOYOTA.COROLLA, True, COROLLA_FW_VERSIONS_NO_DSU),
(EventName.communityFeatureDisallowed, TOYOTA.COROLLA, False, COROLLA_FW_VERSIONS_NO_DSU), (EventName.communityFeatureDisallowed, TOYOTA.COROLLA, False, COROLLA_FW_VERSIONS_NO_DSU),
# community supported car
(EventName.startupMaster, HYUNDAI.KIA_STINGER, True, None),
(EventName.communityFeatureDisallowed, HYUNDAI.KIA_STINGER, False, None),
# dashcamOnly car # dashcamOnly car
(EventName.startupNoControl, MAZDA.CX5, True, CX5_FW_VERSIONS), (EventName.startupNoControl, MAZDA.CX5, True, CX5_FW_VERSIONS),
(EventName.startupNoControl, MAZDA.CX5, False, CX5_FW_VERSIONS), (EventName.startupNoControl, MAZDA.CX5, False, CX5_FW_VERSIONS),

@ -1 +1 @@
3a9687d9daaaf869a37edb7e640ad3e2d3588fcb 94ef06857155a3f5ed38999182178e4e3a11f9d5

@ -49,7 +49,7 @@ TogglesPanel::TogglesPanel(QWidget *parent) : ListWidget(parent) {
this)); this));
addItem(new ParamControl("CommunityFeaturesToggle", addItem(new ParamControl("CommunityFeaturesToggle",
"Enable Community Features", "Enable Community Features",
"Use features from the open source community that are not maintained or supported by comma.ai and have not been confirmed to meet the standard safety model. These features include community supported cars and community supported hardware. Be extra cautious when using these features", "Use features, such as community supported hardware, from the open source community that are not maintained or supported by comma.ai and have not been confirmed to meet the standard safety model. Be extra cautious when using these features",
"../assets/offroad/icon_shell.png", "../assets/offroad/icon_shell.png",
this)); this));

Loading…
Cancel
Save