Car interfaces: assert reasonable centerToFront range (#27356)

* assert reasonable centerToFront values

* comment

* fix Bolt centerToFront

* Update ref_commit
pull/27276/head
Shane Smiskol 2 years ago committed by GitHub
parent 48b059d367
commit 89934b35d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      selfdrive/car/gm/interface.py
  2. 3
      selfdrive/car/tests/test_car_interfaces.py
  3. 2
      selfdrive/test/process_replay/ref_commit

@ -213,7 +213,7 @@ class CarInterface(CarInterfaceBase):
ret.mass = 1669. + STD_CARGO_KG
ret.wheelbase = 2.63779
ret.steerRatio = 16.8
ret.centerToFront = 2.15 # measured
ret.centerToFront = ret.wheelbase * 0.4
tire_stiffness_factor = 1.0
ret.steerActuatorDelay = 0.12
CarInterfaceBase.configure_torque_tune(candidate, ret.lateralTuning)

@ -32,7 +32,8 @@ class TestCarInterfaces(unittest.TestCase):
self.assertGreater(car_params.mass, 1)
self.assertGreater(car_params.wheelbase, 0)
self.assertGreater(car_params.centerToFront, 0)
# centerToFront is center of gravity to front wheels, assert a reasonable range
self.assertTrue(car_params.wheelbase * 0.3 < car_params.centerToFront < car_params.wheelbase * 0.7)
self.assertGreater(car_params.maxLateralAccel, 0)
# Longitudinal sanity checks

@ -1 +1 @@
c7bb411b37ab7ff573402b6e4fa24f796cbb2ee8
fbb99ee7dc0336062e6785814af82e359dcdd9bf

Loading…
Cancel
Save