From 8adba51649e06afc93b904c14e89f62b54f4e92a Mon Sep 17 00:00:00 2001 From: robin-reckmann Date: Wed, 27 Oct 2021 23:46:40 +0900 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Willem Melching --- selfdrive/car/fw_versions.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/selfdrive/car/fw_versions.py b/selfdrive/car/fw_versions.py index d063a2da79..34811ebd0d 100755 --- a/selfdrive/car/fw_versions.py +++ b/selfdrive/car/fw_versions.py @@ -71,10 +71,10 @@ MAZDA_VERSION_REQUEST = bytes([uds.SERVICE_TYPE.READ_DATA_BY_IDENTIFIER]) + \ MAZDA_VERSION_RESPONSE = bytes([uds.SERVICE_TYPE.READ_DATA_BY_IDENTIFIER + 0x40]) + \ p16(uds.DATA_IDENTIFIER_TYPE.VEHICLE_MANUFACTURER_ECU_SOFTWARE_NUMBER) -NISSAN_DIAGNOSTIC_REQUEST = b'\x10\xc0' +NISSAN_KWP_DIAGNOSTIC_REQUEST = bytes([uds.SERVICE_TYPE.DIAGNOSTIC_SESSION_CONTROL, 0xc0]) NISSAN_DIAGNOSTIC_RESPONSE = b'\x50\xc0' -NISSAN_VERSION_REQUEST = b'\x21\x83' +NISSAN_KWP_VERSION_REQUEST = b'\x21\x83' NISSAN_VERSION_RESPONSE = b'\x61\x83' NISSAN_VERSION_REQUEST_STANDARD = bytes([uds.SERVICE_TYPE.READ_DATA_BY_IDENTIFIER]) + \