From 8addbe1f0d9174cf0a0406218414e19ee454afe3 Mon Sep 17 00:00:00 2001
From: Shane Smiskol <shane@smiskol.com>
Date: Mon, 29 Jan 2024 17:23:35 -0800
Subject: [PATCH] happy?1

---
 selfdrive/car/gm/fingerprints.py | 2 +-
 selfdrive/car/gm/values.py       | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/selfdrive/car/gm/fingerprints.py b/selfdrive/car/gm/fingerprints.py
index f3455ba403..815234c2e7 100644
--- a/selfdrive/car/gm/fingerprints.py
+++ b/selfdrive/car/gm/fingerprints.py
@@ -58,7 +58,7 @@ FINGERPRINTS = {
   }],
 }
 
-FW_VERSIONS = {
+FW_VERSIONS: dict[str, dict[tuple, list[bytes]]] = {
   CAR.BOLT_EUV: {
     (Ecu.fwdCamera, 0x24b, None): [],
   }
diff --git a/selfdrive/car/gm/values.py b/selfdrive/car/gm/values.py
index 2210cd43ae..7ce64ca0fe 100644
--- a/selfdrive/car/gm/values.py
+++ b/selfdrive/car/gm/values.py
@@ -145,10 +145,14 @@ class CanBus:
   DROPPED = 192
 
 
+# In a Data Module an identifier is a string which is used to identify an object,
+# either by itself or in conjunction with the identifiers of parent objects.
+# The identifier string must be one continuous string and cannot contain spaces
+# nor certain reserved characters or consist entirely of a reserved keyword.
 GM_SOFTWARE_MODULE_1_REQUEST = b'\x1a\xc1'
 GM_SOFTWARE_MODULE_2_REQUEST = b'\x1a\xc2'
 GM_SOFTWARE_MODULE_3_REQUEST = b'\x1a\xc3'
-GM_END_MODEL_PART_NUMBER_REQUEST = b'\x1a\xcb'
+GM_END_MODEL_PART_NUMBER_REQUEST = b'\x1a\xcb'  # end model part usually returns results online, base model not so much
 GM_BASE_MODEL_PART_NUMBER_REQUEST = b'\x1a\xcc'
 GM_FW_RESPONSE = b'\x5a'