From 8b741261cf4538ab88f42f18837ba13d71bcc0de Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Mon, 19 Sep 2022 14:06:03 -0700 Subject: [PATCH] loggerd: add params test cases (#25843) --- selfdrive/loggerd/tests/test_loggerd.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/selfdrive/loggerd/tests/test_loggerd.py b/selfdrive/loggerd/tests/test_loggerd.py index b0907c54af..a2138b0aa6 100755 --- a/selfdrive/loggerd/tests/test_loggerd.py +++ b/selfdrive/loggerd/tests/test_loggerd.py @@ -83,8 +83,10 @@ class TestLoggerd(unittest.TestCase): ("GitRemote", "gitRemote", "remote"), ] params = Params() + params.clear_all() for k, _, v in fake_params: params.put(k, v) + params.put("LaikadEphemeris", "abc") lr = list(LogReader(str(self._gen_bootlog()))) initData = lr[0].initData @@ -99,8 +101,14 @@ class TestLoggerd(unittest.TestCase): with open("/proc/version") as f: self.assertEqual(initData.kernelVersion, f.read()) - for _, k, v in fake_params: - self.assertEqual(getattr(initData, k), v) + # check params + logged_params = {entry.key: entry.value for entry in initData.params.entries} + expected_params = set(k for k, _, __ in fake_params) | {'LaikadEphemeris'} + assert set(logged_params.keys()) == expected_params, set(logged_params.keys()) ^ expected_params + assert logged_params['LaikadEphemeris'] == b'', f"DONT_LOG param value was logged: {repr(logged_params['LaikadEphemeris'])}" + for param_key, initData_key, v in fake_params: + self.assertEqual(getattr(initData, initData_key), v) + self.assertEqual(logged_params[param_key].decode(), v) def test_rotation(self): os.environ["LOGGERD_TEST"] = "1"