From 8dc8b291ec85e28dc447c7f07c5576e2386ca01d Mon Sep 17 00:00:00 2001
From: Shane Smiskol <shane@smiskol.com>
Date: Wed, 7 Aug 2024 17:18:23 -0700
Subject: [PATCH] move to can_definitions

---
 selfdrive/car/__init__.py             |  5 ++---
 selfdrive/car/can_definitions.py      |  3 ++-
 selfdrive/car/interfaces.py           | 11 +++++------
 selfdrive/car/isotp_parallel_query.py |  6 +++---
 4 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/selfdrive/car/__init__.py b/selfdrive/car/__init__.py
index fa69b75e9f..68193e74d4 100644
--- a/selfdrive/car/__init__.py
+++ b/selfdrive/car/__init__.py
@@ -9,11 +9,10 @@ import capnp
 
 from cereal import car
 from panda.python.uds import SERVICE_TYPE
+from openpilot.selfdrive.car.can_definitions import CanMsg
 from openpilot.selfdrive.car.docs_definitions import CarDocs
 from openpilot.selfdrive.car.helpers import clip, interp
 
-CanMsgType = tuple[int, bytes, int]
-
 # set up logging
 carlog = logging.getLogger('carlog')
 carlog.setLevel(logging.INFO)
@@ -195,7 +194,7 @@ def get_friction(lateral_accel_error: float, lateral_accel_deadzone: float, fric
   return friction
 
 
-def make_can_msg(addr: int, dat: bytes, bus: int) -> CanMsgType:
+def make_can_msg(addr: int, dat: bytes, bus: int) -> CanMsg:
   return addr, dat, bus
 
 
diff --git a/selfdrive/car/can_definitions.py b/selfdrive/car/can_definitions.py
index f43e03af80..a4228ec33d 100644
--- a/selfdrive/car/can_definitions.py
+++ b/selfdrive/car/can_definitions.py
@@ -1,7 +1,8 @@
 from collections.abc import Callable
 from dataclasses import dataclass
 
-CanSendCallable = Callable[[list[tuple[int, bytes, int]]], None]
+CanMsg = tuple[int, bytes, int]
+CanSendCallable = Callable[[list[CanMsg]], None]
 
 
 @dataclass
diff --git a/selfdrive/car/interfaces.py b/selfdrive/car/interfaces.py
index 1b79844718..9689a01837 100644
--- a/selfdrive/car/interfaces.py
+++ b/selfdrive/car/interfaces.py
@@ -12,9 +12,8 @@ from functools import cache
 from cereal import car
 from openpilot.common.basedir import BASEDIR
 from openpilot.common.simple_kalman import KF1D, get_kalman_gain
-from openpilot.selfdrive.car import CanMsgType, DT_CTRL, apply_hysteresis, gen_empty_fingerprint, scale_rot_inertia, scale_tire_stiffness, get_friction, \
-                                    STD_CARGO_KG
-from openpilot.selfdrive.car.can_definitions import CanSendCallable
+from openpilot.selfdrive.car import DT_CTRL, apply_hysteresis, gen_empty_fingerprint, scale_rot_inertia, scale_tire_stiffness, get_friction, STD_CARGO_KG
+from openpilot.selfdrive.car.can_definitions import CanMsg, CanSendCallable
 from openpilot.selfdrive.car.conversions import Conversions as CV
 from openpilot.selfdrive.car.helpers import clip
 from openpilot.selfdrive.car.values import PLATFORMS
@@ -110,7 +109,7 @@ class CarInterfaceBase(ABC):
     dbc_name = "" if self.cp is None else self.cp.dbc_name
     self.CC: CarControllerBase = CarController(dbc_name, CP)
 
-  def apply(self, c: car.CarControl, now_nanos: int) -> tuple[car.CarControl.Actuators, list[CanMsgType]]:
+  def apply(self, c: car.CarControl, now_nanos: int) -> tuple[car.CarControl.Actuators, list[CanMsg]]:
     return self.CC.update(c, self.CS, now_nanos)
 
   @staticmethod
@@ -230,7 +229,7 @@ class CarInterfaceBase(ABC):
   def _update(self, c: car.CarControl) -> car.CarState:
     pass
 
-  def update(self, c: car.CarControl, can_packets: list[tuple[int, list[CanMsgType]]]) -> car.CarState:
+  def update(self, c: car.CarControl, can_packets: list[tuple[int, list[CanMsg]]]) -> car.CarState:
     # parse can
     for cp in self.can_parsers:
       if cp is not None:
@@ -469,7 +468,7 @@ class CarControllerBase(ABC):
     self.frame = 0
 
   @abstractmethod
-  def update(self, CC: car.CarControl.Actuators, CS: car.CarState, now_nanos: int) -> tuple[car.CarControl.Actuators, list[CanMsgType]]:
+  def update(self, CC: car.CarControl.Actuators, CS: car.CarState, now_nanos: int) -> tuple[car.CarControl.Actuators, list[CanMsg]]:
     pass
 
 
diff --git a/selfdrive/car/isotp_parallel_query.py b/selfdrive/car/isotp_parallel_query.py
index 0d2d1861bc..bd8d43d034 100644
--- a/selfdrive/car/isotp_parallel_query.py
+++ b/selfdrive/car/isotp_parallel_query.py
@@ -3,8 +3,8 @@ from collections import defaultdict
 from functools import partial
 from types import SimpleNamespace
 
-from openpilot.selfdrive.car import carlog, CanMsgType
-from openpilot.selfdrive.car.can_definitions import CanSendCallable
+from openpilot.selfdrive.car import carlog
+from openpilot.selfdrive.car.can_definitions import CanMsg, CanSendCallable
 from openpilot.selfdrive.car.fw_query_definitions import AddrType
 from panda.python.uds import CanClient, IsoTpMessage, FUNCTIONAL_ADDRS, get_rx_addr_for_tx_addr
 
@@ -27,7 +27,7 @@ class IsoTpParallelQuery:
       assert tx_addr not in FUNCTIONAL_ADDRS, f"Functional address should be defined in functional_addrs: {hex(tx_addr)}"
 
     self.msg_addrs = {tx_addr: get_rx_addr_for_tx_addr(tx_addr[0], rx_offset=response_offset) for tx_addr in real_addrs}
-    self.msg_buffer: dict[int, list[CanMsgType]] = defaultdict(list)
+    self.msg_buffer: dict[int, list[CanMsg]] = defaultdict(list)
 
   def rx(self):
     """Drain can socket and sort messages into buffers based on address"""