test_util.cc: do not compare file contents in REQUIRE (#29861)

old-commit-hash: 95ae87659d
test-msgs
Dean Lee 2 years ago committed by GitHub
parent d1fc58bf81
commit 9351c70889
  1. 6
      common/tests/test_util.cc

@ -38,7 +38,8 @@ TEST_CASE("util::read_file") {
std::string content = random_bytes(64 * 1024); std::string content = random_bytes(64 * 1024);
write(fd, content.c_str(), content.size()); write(fd, content.c_str(), content.size());
std::string ret = util::read_file(filename); std::string ret = util::read_file(filename);
REQUIRE(ret == content); bool equal = (ret == content);
REQUIRE(equal);
close(fd); close(fd);
} }
SECTION("read directory") { SECTION("read directory") {
@ -108,7 +109,8 @@ TEST_CASE("util::safe_fwrite") {
REQUIRE(ret == 0); REQUIRE(ret == 0);
ret = fclose(f); ret = fclose(f);
REQUIRE(ret == 0); REQUIRE(ret == 0);
REQUIRE(dat == util::read_file(filename)); bool equal = (dat == util::read_file(filename));
REQUIRE(equal);
} }
TEST_CASE("util::create_directories") { TEST_CASE("util::create_directories") {

Loading…
Cancel
Save