From 984fc2008de442af8763026972a20c17b119cec6 Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Mon, 6 Sep 2021 19:21:06 -0700 Subject: [PATCH] handle missing routes better in test car models old-commit-hash: 81006b03c209aa93211e65c2bbbe1376df3522e7 --- .github/workflows/selfdrive_tests.yaml | 4 +--- selfdrive/test/test_models.py | 6 ++++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/selfdrive_tests.yaml b/.github/workflows/selfdrive_tests.yaml index fe211aa480..73784fdfec 100644 --- a/.github/workflows/selfdrive_tests.yaml +++ b/.github/workflows/selfdrive_tests.yaml @@ -309,8 +309,6 @@ jobs: - name: Test car models run: | ${{ env.RUN }} "scons -j$(nproc) && \ - FILEREADER_CACHE=1 coverage run --parallel-mode -m nose --processes=4 --process-timeout=120 \ - selfdrive/test/test_models.py && \ - coverage combine" + coverage run selfdrive/test/test_models.py" - name: Upload coverage to Codecov run: bash <(curl -s https://codecov.io/bash) -v -F test_car_models diff --git a/selfdrive/test/test_models.py b/selfdrive/test/test_models.py index 7967d79b01..0d82fd2203 100755 --- a/selfdrive/test/test_models.py +++ b/selfdrive/test/test_models.py @@ -52,8 +52,10 @@ class TestCarModel(unittest.TestCase): lr = LogReader(get_url(ROUTES[cls.car_model], seg)) break except Exception: - if seg == 0: - raise + lr = None + + if lr is None: + raise Exception("Route not found. Is it uploaded?") can_msgs = [] fingerprint = {i: dict() for i in range(3)}