ci: overwrite previous comment for model_replay (#35209)

* less

* test

* fix

* cleanup
pull/35109/head^2
Maxime Desroches 4 months ago committed by GitHub
parent 3fd05d2ace
commit 997a99926c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      selfdrive/test/process_replay/model_replay.py
  2. 3
      tools/lib/github_utils.py

@ -123,7 +123,7 @@ def comment_replay_report(proposed, master, full_logs):
diff_plots = create_table("Model Replay Differences", diff_files, link, open_table=True)
all_plots = create_table("All Model Replay Plots", files, link)
comment = f"ref for commit {commit}: {link}/{log_name}" + diff_plots + all_plots
GITHUB.comment_on_pr(comment, PR_BRANCH)
GITHUB.comment_on_pr(comment, PR_BRANCH, "commaci-public", True)
def trim_logs_to_max_frames(logs, max_frames, frs_types, include_all_types):
all_msgs = []

@ -87,8 +87,8 @@ class GithubUtils:
def comment_on_pr(self, comment, pr_branch, commenter="", overwrite=False):
pr_number = self.get_pr_number(pr_branch)
data = f'{{"body": "{comment}"}}'
github_path = f'issues/{pr_number}/comments'
if overwrite:
github_path = f'issues/{pr_number}/comments'
r = self.api_call(github_path)
comments = [x['id'] for x in r.json() if x['user']['login'] == commenter]
if comments:
@ -96,7 +96,6 @@ class GithubUtils:
self.api_call(github_path, data=data, method=HTTPMethod.PATCH)
return
github_path=f'issues/{pr_number}/comments'
self.api_call(github_path, data=data, method=HTTPMethod.POST)
# upload files to github and comment them on the pr

Loading…
Cancel
Save