From 9983389ffebe3383736111b0b4ad762aa9ef580b Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Mon, 28 Sep 2020 17:47:38 +0800
Subject: [PATCH] close lock_fd if flock failed (#2231)

---
 selfdrive/common/params.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/selfdrive/common/params.cc b/selfdrive/common/params.cc
index c3dd70ed27..d511ebf415 100644
--- a/selfdrive/common/params.cc
+++ b/selfdrive/common/params.cc
@@ -305,7 +305,10 @@ int read_db_all(std::map<std::string, std::string> *params, bool persistent_para
   if (lock_fd < 0) return -1;
 
   err = flock(lock_fd, LOCK_SH);
-  if (err < 0) return err;
+  if (err < 0) {
+    close(lock_fd);
+    return err;
+  }
 
   std::string key_path = util::string_format("%s/d", params_path);
   DIR *d = opendir(key_path.c_str());