From 9b5e02d66826cb39113a9f8fb02982a9d1cc8246 Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Sat, 4 Nov 2023 02:16:58 +0800 Subject: [PATCH] cabana: fix QChart leak (#30369) fix QChart leak old-commit-hash: f5279284f5b4d993a181e8ba2d9a6ec7985130d5 --- tools/cabana/chart/chart.cc | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/cabana/chart/chart.cc b/tools/cabana/chart/chart.cc index dee7cc5248..28d122576c 100644 --- a/tools/cabana/chart/chart.cc +++ b/tools/cabana/chart/chart.cc @@ -25,20 +25,18 @@ const int AXIS_X_TOP_MARGIN = 4; static inline bool xLessThan(const QPointF &p, float x) { return p.x() < x; } ChartView::ChartView(const std::pair &x_range, ChartsWidget *parent) - : charts_widget(parent), tip_label(this), QChartView(nullptr, parent) { + : charts_widget(parent), tip_label(this), QChartView(parent) { series_type = (SeriesType)settings.chart_series_type; - QChart *chart = new QChart(); - chart->setBackgroundVisible(false); + chart()->setBackgroundVisible(false); axis_x = new QValueAxis(this); axis_y = new QValueAxis(this); - chart->addAxis(axis_x, Qt::AlignBottom); - chart->addAxis(axis_y, Qt::AlignLeft); - chart->legend()->layout()->setContentsMargins(0, 0, 0, 0); - chart->legend()->setShowToolTips(true); - chart->setMargins({0, 0, 0, 0}); + chart()->addAxis(axis_x, Qt::AlignBottom); + chart()->addAxis(axis_y, Qt::AlignLeft); + chart()->legend()->layout()->setContentsMargins(0, 0, 0, 0); + chart()->legend()->setShowToolTips(true); + chart()->setMargins({0, 0, 0, 0}); axis_x->setRange(x_range.first, x_range.second); - setChart(chart); createToolButtons(); setRubberBand(QChartView::HorizontalRubberBand);