long test, not negative test

Aubrey Wahl 7 days ago
parent 62e5d391b3
commit 9d681db03f
  1. 5
      .github/workflows/selfdrive_tests.yaml
  2. 6
      selfdrive/car/tests/test_models.py

@ -238,13 +238,10 @@ jobs:
- name: Build openpilot
run: ${{ env.RUN }} "scons -j$(nproc)"
- name: Test car models
timeout-minutes: ${{ contains(runner.name, 'nsc') && (steps.routes-cache.outputs.cache-hit == 'true') && 1 || 6 }}
timeout-minutes: 15
run: |
${{ env.RUN }} "MAX_EXAMPLES=1 $PYTEST selfdrive/car/tests/test_models.py && \
chmod -R 777 /tmp/comma_download_cache"
env:
NUM_JOBS: 4
JOB_ID: ${{ matrix.job }}
- name: "Upload coverage to Codecov"
uses: codecov/codecov-action@v4
with:

@ -243,10 +243,8 @@ class TestCarModelBase(unittest.TestCase):
if self.safety.safety_rx_hook(to_send) != 1:
failed_addrs[hex(msg.address)] += 1
if self.CP.brand in ("gm", "mazda", "rivian", "tesla"):
self.assertTrue(self.safety.get_ignition_can())
else:
self.assertFalse(self.safety.get_ignition_can())
if self.CP.brand not in ("gm", "mazda", "rivian", "tesla"):
self.assertFalse(self.safety.get_ignition_can())
# ensure all msgs defined in the addr checks are valid
self.safety.safety_tick_current_safety_config()

Loading…
Cancel
Save