From 9d7b18c7e3895768392e4e3a7de1f72729a5a439 Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Sat, 12 Jul 2025 10:49:30 +0800
Subject: [PATCH] cabana: Fix slider visual inconsistency by adjusting groove
 height (#35688)

Fix slider visual inconsistency by adjusting groove height to match handle
---
 tools/cabana/videowidget.cc | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tools/cabana/videowidget.cc b/tools/cabana/videowidget.cc
index 3d715b0319..b817ae1208 100644
--- a/tools/cabana/videowidget.cc
+++ b/tools/cabana/videowidget.cc
@@ -261,14 +261,23 @@ void Slider::paintEvent(QPaintEvent *ev) {
 
   QStyleOptionSlider opt;
   initStyleOption(&opt);
-  QRect r = style()->subControlRect(QStyle::CC_Slider, &opt, QStyle::SC_SliderGroove, this);
-  p.fillRect(r, timeline_colors[(int)TimelineType::None]);
+  QRect handle_rect = style()->subControlRect(QStyle::CC_Slider, &opt, QStyle::SC_SliderHandle, this);
+  QRect groove_rect = style()->subControlRect(QStyle::CC_Slider, &opt, QStyle::SC_SliderGroove, this);
+
+  // Adjust groove height to match handle height
+  int handle_height = handle_rect.height();
+  groove_rect.setHeight(handle_height * 0.5);
+  groove_rect.moveCenter(QPoint(groove_rect.center().x(), rect().center().y()));
+
+  p.fillRect(groove_rect, timeline_colors[(int)TimelineType::None]);
 
   double min = minimum() / factor;
   double max = maximum() / factor;
 
   auto fillRange = [&](double begin, double end, const QColor &color) {
     if (begin > max || end < min) return;
+
+    QRect r = groove_rect;
     r.setLeft(((std::max(min, begin) - min) / (max - min)) * width());
     r.setRight(((std::min(max, end) - min) / (max - min)) * width());
     p.fillRect(r, color);