From a60effc1123254472b16bcd6ef5fbb03a2e4a5f7 Mon Sep 17 00:00:00 2001
From: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed, 14 Apr 2021 21:02:34 -0700
Subject: [PATCH] UI: fix initial toggle state after #20670

---
 selfdrive/ui/qt/widgets/controls.hpp | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/selfdrive/ui/qt/widgets/controls.hpp b/selfdrive/ui/qt/widgets/controls.hpp
index c5814ebd2f..62fff67213 100644
--- a/selfdrive/ui/qt/widgets/controls.hpp
+++ b/selfdrive/ui/qt/widgets/controls.hpp
@@ -116,13 +116,15 @@ class ParamControl : public ToggleControl {
   Q_OBJECT
 
 public:
-  ParamControl(const QString &param, const QString &title, const QString &desc, const QString &icon, QWidget *parent = nullptr) : ToggleControl(title, desc, icon, parent) {
-    // set initial state from param
-    if (Params().getBool(param.toStdString().c_str())) {
+  ParamControl(const QString &param, const QString &title, const QString &desc, const QString &icon, QWidget *parent = nullptr) : ToggleControl(title, desc, icon, false, parent) {
+    if (params.getBool(param.toStdString().c_str())) {
       toggle.togglePosition();
     }
-    QObject::connect(this, &ToggleControl::toggleFlipped, [=](int state) {
-      Params().putBool(param.toStdString().c_str(), (bool)state);
+    QObject::connect(this, &ToggleControl::toggleFlipped, [=](bool state) {
+      params.putBool(param.toStdString().c_str(), state);
     });
   }
+
+private:
+  Params params;
 };