diff --git a/selfdrive/ui/paint.cc b/selfdrive/ui/paint.cc index cdaee02036..36faf69a69 100644 --- a/selfdrive/ui/paint.cc +++ b/selfdrive/ui/paint.cc @@ -97,8 +97,7 @@ static void ui_draw_circle_image(NVGcontext *vg, int x, int y, int size, int ima nvgCircle(vg, x, y + (bdr_s * 1.5), size); nvgFillColor(vg, color); nvgFill(vg); - const Rect rect = {x - (img_size / 2), img_y ? img_y : y - (size / 4), img_size, img_size}; - ui_draw_image(vg, rect, image, img_alpha); + ui_draw_image(vg, {x - (img_size / 2), img_y ? img_y : y - (size / 4), img_size, img_size}, image, img_alpha); } static void ui_draw_circle_image(NVGcontext *vg, int x, int y, int size, int image, bool active) { @@ -231,18 +230,17 @@ static void ui_draw_vision_maxspeed(UIState *s) { const bool is_cruise_set = maxspeed != 0 && maxspeed != SET_SPEED_NA; if (is_cruise_set && !s->is_metric) { maxspeed *= 0.6225; } - auto [x, y, w, h] = std::tuple(s->scene.viz_rect.x + (bdr_s * 2), s->scene.viz_rect.y + (bdr_s * 1.5), 184, 202); - - ui_draw_rect(s->vg, x, y, w, h, COLOR_BLACK_ALPHA(100), 30); - ui_draw_rect(s->vg, x, y, w, h, COLOR_WHITE_ALPHA(100), 20, 10); + const Rect rect = {s->scene.viz_rect.x + (bdr_s * 2), int(s->scene.viz_rect.y + (bdr_s * 1.5)), 184, 202}; + ui_fill_rect(s->vg, rect, COLOR_BLACK_ALPHA(100), 30.); + ui_draw_rect(s->vg, rect, COLOR_WHITE_ALPHA(100), 10, 20.); nvgTextAlign(s->vg, NVG_ALIGN_CENTER | NVG_ALIGN_BASELINE); - ui_draw_text(s->vg, x + w / 2, 148, "MAX", 26 * 2.5, COLOR_WHITE_ALPHA(is_cruise_set ? 200 : 100), s->font_sans_regular); + ui_draw_text(s->vg, rect.centerX(), 148, "MAX", 26 * 2.5, COLOR_WHITE_ALPHA(is_cruise_set ? 200 : 100), s->font_sans_regular); if (is_cruise_set) { const std::string maxspeed_str = std::to_string((int)std::nearbyint(maxspeed)); - ui_draw_text(s->vg, x + w / 2, 242, maxspeed_str.c_str(), 48 * 2.5, COLOR_WHITE, s->font_sans_bold); + ui_draw_text(s->vg, rect.centerX(), 242, maxspeed_str.c_str(), 48 * 2.5, COLOR_WHITE, s->font_sans_bold); } else { - ui_draw_text(s->vg, x + w / 2, 242, "N/A", 42 * 2.5, COLOR_WHITE_ALPHA(100), s->font_sans_semibold); + ui_draw_text(s->vg, rect.centerX(), 242, "N/A", 42 * 2.5, COLOR_WHITE_ALPHA(100), s->font_sans_semibold); } } @@ -294,25 +292,25 @@ static void ui_draw_driver_view(UIState *s) { const int blackout_w = rect.w - valid_rect.w; NVGpaint gradient = nvgLinearGradient(s->vg, blackout_x, rect.y, blackout_x + blackout_w, rect.y, COLOR_BLACK_ALPHA(is_rhd ? 255 : 0), COLOR_BLACK_ALPHA(is_rhd ? 0 : 255)); - ui_draw_rect(s->vg, blackout_x, rect.y, blackout_w, rect.h, gradient); - ui_draw_rect(s->vg, blackout_x, rect.y, blackout_w, rect.h, COLOR_BLACK_ALPHA(144)); + ui_fill_rect(s->vg, {blackout_x, rect.y, blackout_w, rect.h}, gradient); + ui_fill_rect(s->vg, {blackout_x, rect.y, blackout_w, rect.h}, COLOR_BLACK_ALPHA(144)); // border - ui_draw_rect(s->vg, rect.x, rect.y, rect.w, rect.h, bg_colors[STATUS_OFFROAD], 0, 1); + ui_draw_rect(s->vg, rect, bg_colors[STATUS_OFFROAD], 1); const bool face_detected = s->scene.dmonitoring_state.getFaceDetected(); if (face_detected) { auto fxy_list = s->scene.driver_state.getFacePosition(); float face_x = fxy_list[0]; float face_y = fxy_list[1]; - float fbox_x = valid_rect.centerX() + (is_rhd ? face_x : -face_x) * valid_rect.w; - float fbox_y = valid_rect.centerY() + face_y * valid_rect.h; + int fbox_x = valid_rect.centerX() + (is_rhd ? face_x : -face_x) * valid_rect.w; + int fbox_y = valid_rect.centerY() + face_y * valid_rect.h; float alpha = 0.2; if (face_x = std::abs(face_x), face_y = std::abs(face_y); face_x <= 0.35 && face_y <= 0.4) alpha = 0.8 - (face_x > face_y ? face_x : face_y) * 0.6 / 0.375; - const float box_size = 0.6 * rect.h / 2; - ui_draw_rect(s->vg, fbox_x - box_size / 2, fbox_y - box_size / 2, box_size, box_size, nvgRGBAf(1.0, 1.0, 1.0, alpha), 35, 10); + const int box_size = 0.6 * rect.h / 2; + ui_draw_rect(s->vg, {fbox_x - box_size / 2, fbox_y - box_size / 2, box_size, box_size}, nvgRGBAf(1.0, 1.0, 1.0, alpha), 10, 35.); } // draw face icon @@ -329,7 +327,7 @@ static void ui_draw_vision_header(UIState *s) { viz_rect.x, viz_rect.y+header_h, nvgRGBAf(0,0,0,0.45), nvgRGBAf(0,0,0,0)); - ui_draw_rect(s->vg, viz_rect.x, viz_rect.y, viz_rect.w, header_h, gradient); + ui_fill_rect(s->vg, {viz_rect.x, viz_rect.y, viz_rect.w, header_h}, gradient); ui_draw_vision_maxspeed(s); ui_draw_vision_speed(s); @@ -354,36 +352,33 @@ static void ui_draw_vision_alert(UIState *s) { NVGcolor color = bg_colors[s->status]; color.a *= get_alert_alpha(scene->alert_blinking_rate); - int alr_s = alert_size_map[scene->alert_size]; - - const int alr_x = scene->viz_rect.x - bdr_s; - const int alr_w = scene->viz_rect.w + (bdr_s * 2); - const int alr_h = alr_s + bdr_s; - const int alr_y = s->fb_h - alr_h; + const int alr_h = alert_size_map[scene->alert_size] + bdr_s; + const Rect rect = {.x = scene->viz_rect.x - bdr_s, + .y = s->fb_h - alr_h, + .w = scene->viz_rect.w + (bdr_s * 2), + .h = alr_h}; - ui_draw_rect(s->vg, alr_x, alr_y, alr_w, alr_h, color); - - NVGpaint gradient = nvgLinearGradient(s->vg, alr_x, alr_y, alr_x, alr_y+alr_h, - nvgRGBAf(0.0,0.0,0.0,0.05), nvgRGBAf(0.0,0.0,0.0,0.35)); - ui_draw_rect(s->vg, alr_x, alr_y, alr_w, alr_h, gradient); + ui_fill_rect(s->vg, rect, color); + ui_fill_rect(s->vg, rect, nvgLinearGradient(s->vg, rect.x, rect.y, rect.x, rect.bottom(), + nvgRGBAf(0.0, 0.0, 0.0, 0.05), nvgRGBAf(0.0, 0.0, 0.0, 0.35))); nvgFillColor(s->vg, COLOR_WHITE); nvgTextAlign(s->vg, NVG_ALIGN_CENTER | NVG_ALIGN_BASELINE); if (scene->alert_size == cereal::ControlsState::AlertSize::SMALL) { - ui_draw_text(s->vg, alr_x+alr_w/2, alr_y+alr_h/2+15, scene->alert_text1.c_str(), 40*2.5, COLOR_WHITE, s->font_sans_semibold); + ui_draw_text(s->vg, rect.centerX(), rect.centerY() + 15, scene->alert_text1.c_str(), 40*2.5, COLOR_WHITE, s->font_sans_semibold); } else if (scene->alert_size == cereal::ControlsState::AlertSize::MID) { - ui_draw_text(s->vg, alr_x+alr_w/2, alr_y+alr_h/2-45, scene->alert_text1.c_str(), 48*2.5, COLOR_WHITE, s->font_sans_bold); - ui_draw_text(s->vg, alr_x+alr_w/2, alr_y+alr_h/2+75, scene->alert_text2.c_str(), 36*2.5, COLOR_WHITE, s->font_sans_regular); + ui_draw_text(s->vg, rect.centerX(), rect.centerY() - 45, scene->alert_text1.c_str(), 48*2.5, COLOR_WHITE, s->font_sans_bold); + ui_draw_text(s->vg, rect.centerX(), rect.centerY() + 75, scene->alert_text2.c_str(), 36*2.5, COLOR_WHITE, s->font_sans_regular); } else if (scene->alert_size == cereal::ControlsState::AlertSize::FULL) { nvgFontSize(s->vg, (longAlert1?72:96)*2.5); nvgFontFaceId(s->vg, s->font_sans_bold); nvgTextAlign(s->vg, NVG_ALIGN_CENTER | NVG_ALIGN_MIDDLE); - nvgTextBox(s->vg, alr_x, alr_y+(longAlert1?360:420), alr_w-60, scene->alert_text1.c_str(), NULL); + nvgTextBox(s->vg, rect.x, rect.y+(longAlert1?360:420), rect.w-60, scene->alert_text1.c_str(), NULL); nvgFontSize(s->vg, 48*2.5); nvgFontFaceId(s->vg, s->font_sans_regular); nvgTextAlign(s->vg, NVG_ALIGN_CENTER | NVG_ALIGN_BOTTOM); - nvgTextBox(s->vg, alr_x, alr_h-(longAlert1?300:360), alr_w-60, scene->alert_text2.c_str(), NULL); + nvgTextBox(s->vg, rect.x, rect.h-(longAlert1?300:360), rect.w-60, scene->alert_text2.c_str(), NULL); } } @@ -466,25 +461,27 @@ void ui_draw_image(NVGcontext *vg, const Rect &r, int image, float alpha){ nvgFill(vg); } -void ui_draw_rect(NVGcontext *vg, float x, float y, float w, float h, NVGcolor color, float r, int width) { +void ui_draw_rect(NVGcontext *vg, const Rect &r, NVGcolor color, int width, float radius) { nvgBeginPath(vg); - r > 0 ? nvgRoundedRect(vg, x, y, w, h, r) : nvgRect(vg, x, y, w, h); - if (width) { - nvgStrokeColor(vg, color); - nvgStrokeWidth(vg, width); - nvgStroke(vg); - } else { - nvgFillColor(vg, color); - nvgFill(vg); - } + radius > 0 ? nvgRoundedRect(vg, r.x, r.y, r.w, r.h, radius) : nvgRect(vg, r.x, r.y, r.w, r.h); + nvgStrokeColor(vg, color); + nvgStrokeWidth(vg, width); + nvgStroke(vg); } -void ui_draw_rect(NVGcontext *vg, float x, float y, float w, float h, NVGpaint &paint, float r){ +static inline void fill_rect(NVGcontext *vg, const Rect &r, const NVGcolor *color, const NVGpaint *paint, float radius) { nvgBeginPath(vg); - r > 0? nvgRoundedRect(vg, x, y, w, h, r) : nvgRect(vg, x, y, w, h); - nvgFillPaint(vg, paint); + radius > 0? nvgRoundedRect(vg, r.x, r.y, r.w, r.h, radius) : nvgRect(vg, r.x, r.y, r.w, r.h); + if (color) nvgFillColor(vg, *color); + if (paint) nvgFillPaint(vg, *paint); nvgFill(vg); } +void ui_fill_rect(NVGcontext *vg, const Rect &r, const NVGcolor &color, float radius) { + fill_rect(vg, r, &color, nullptr, radius); +} +void ui_fill_rect(NVGcontext *vg, const Rect &r, const NVGpaint &paint, float radius){ + fill_rect(vg, r, nullptr, &paint, radius); +} static const char frame_vertex_shader[] = #ifdef NANOVG_GL3_IMPLEMENTATION diff --git a/selfdrive/ui/paint.hpp b/selfdrive/ui/paint.hpp index 7119579dee..62a8c6a05b 100644 --- a/selfdrive/ui/paint.hpp +++ b/selfdrive/ui/paint.hpp @@ -4,6 +4,7 @@ bool car_space_to_full_frame(const UIState *s, float in_x, float in_y, float in_z, vertex_data *out, float margin=0.0); void ui_draw(UIState *s); void ui_draw_image(NVGcontext *vg, const Rect &r, int image, float alpha); -void ui_draw_rect(NVGcontext *vg, float x, float y, float w, float h, NVGcolor color, float r = 0, int width = 0); -void ui_draw_rect(NVGcontext *vg, float x, float y, float w, float h, NVGpaint &paint, float r = 0); +void ui_draw_rect(NVGcontext *vg, const Rect &r, NVGcolor color, int width, float radius = 0); +void ui_fill_rect(NVGcontext *vg, const Rect &r, const NVGpaint &paint, float radius = 0); +void ui_fill_rect(NVGcontext *vg, const Rect &r, const NVGcolor &color, float radius = 0); void ui_nvg_init(UIState *s); diff --git a/selfdrive/ui/sidebar.cc b/selfdrive/ui/sidebar.cc index 1b2699fc79..2ba9020f9e 100644 --- a/selfdrive/ui/sidebar.cc +++ b/selfdrive/ui/sidebar.cc @@ -12,7 +12,7 @@ static void draw_background(UIState *s) { #else const NVGcolor color = nvgRGBA(0x39, 0x39, 0x39, 0xff); #endif - ui_draw_rect(s->vg, 0, 0, sbr_w, s->fb_h, color); + ui_fill_rect(s->vg, {0, 0, sbr_w, s->fb_h}, color); } static void draw_settings_button(UIState *s) { @@ -32,16 +32,15 @@ static void draw_network_strength(UIState *s) { {cereal::ThermalData::NetworkStrength::MODERATE, 3}, {cereal::ThermalData::NetworkStrength::GOOD, 4}, {cereal::ThermalData::NetworkStrength::GREAT, 5}}; - const Rect rect = {58, 196, 176, 27}; const int img_idx = s->scene.thermal.getNetworkType() == cereal::ThermalData::NetworkType::NONE ? 0 : network_strength_map[s->scene.thermal.getNetworkStrength()]; - ui_draw_image(s->vg, rect, s->img_network[img_idx], 1.0f); + ui_draw_image(s->vg, {58, 196, 176, 27}, s->img_network[img_idx], 1.0f); } static void draw_battery_icon(UIState *s) { int battery_img = s->scene.thermal.getBatteryStatus() == "Charging" ? s->img_battery_charging : s->img_battery; const Rect rect = {160, 255, 76, 36}; - ui_draw_rect(s->vg, rect.x + 6, rect.y + 5, - ((rect.w - 19) * (s->scene.thermal.getBatteryPercent() * 0.01)), rect.h - 11, COLOR_WHITE); + ui_fill_rect(s->vg, {rect.x + 6, rect.y + 5, + int((rect.w - 19) * s->scene.thermal.getBatteryPercent() * 0.01), rect.h - 11}, COLOR_WHITE); ui_draw_image(s->vg, rect, battery_img, 1.0f); } @@ -65,11 +64,6 @@ static void draw_network_type(UIState *s) { } static void draw_metric(UIState *s, const char *label_str, const char *value_str, const int severity, const int y_offset, const char *message_str) { - const int metric_x = 30; - const int metric_y = 338 + y_offset; - const int metric_w = 240; - const int metric_h = message_str ? strchr(message_str, '\n') ? 124 : 100 : 148; - NVGcolor status_color; if (severity == 0) { @@ -80,11 +74,11 @@ static void draw_metric(UIState *s, const char *label_str, const char *value_str status_color = COLOR_RED; } - ui_draw_rect(s->vg, metric_x, metric_y, metric_w, metric_h, - severity > 0 ? COLOR_WHITE : COLOR_WHITE_ALPHA(85), 20, 2); + const Rect rect = {30, 338 + y_offset, 240, message_str ? strchr(message_str, '\n') ? 124 : 100 : 148}; + ui_draw_rect(s->vg, rect, severity > 0 ? COLOR_WHITE : COLOR_WHITE_ALPHA(85), 2, 20.); nvgBeginPath(s->vg); - nvgRoundedRectVarying(s->vg, metric_x + 6, metric_y + 6, 18, metric_h - 12, 25, 0, 0, 25); + nvgRoundedRectVarying(s->vg, rect.x + 6, rect.y + 6, 18, rect.h - 12, 25, 0, 0, 25); nvgFillColor(s->vg, status_color); nvgFill(s->vg); @@ -93,19 +87,19 @@ static void draw_metric(UIState *s, const char *label_str, const char *value_str nvgFontSize(s->vg, 78); nvgFontFaceId(s->vg, s->font_sans_bold); nvgTextAlign(s->vg, NVG_ALIGN_LEFT | NVG_ALIGN_MIDDLE); - nvgTextBox(s->vg, metric_x + 50, metric_y + 50, metric_w - 60, value_str, NULL); + nvgTextBox(s->vg, rect.x + 50, rect.y + 50, rect.w - 60, value_str, NULL); nvgFillColor(s->vg, COLOR_WHITE); nvgFontSize(s->vg, 48); nvgFontFaceId(s->vg, s->font_sans_regular); nvgTextAlign(s->vg, NVG_ALIGN_LEFT | NVG_ALIGN_MIDDLE); - nvgTextBox(s->vg, metric_x + 50, metric_y + 50 + 66, metric_w - 60, label_str, NULL); + nvgTextBox(s->vg, rect.x + 50, rect.y + 50 + 66, rect.w - 60, label_str, NULL); } else { nvgFillColor(s->vg, COLOR_WHITE); nvgFontSize(s->vg, 48); nvgFontFaceId(s->vg, s->font_sans_bold); nvgTextAlign(s->vg, NVG_ALIGN_CENTER | NVG_ALIGN_MIDDLE); - nvgTextBox(s->vg, metric_x + 35, metric_y + (strchr(message_str, '\n') ? 40 : 50), metric_w - 50, message_str, NULL); + nvgTextBox(s->vg, rect.x + 35, rect.y + (strchr(message_str, '\n') ? 40 : 50), rect.w - 50, message_str, NULL); } }