From a9b2cd70f018f45db87c65fdec288bc231d35bdd Mon Sep 17 00:00:00 2001 From: dekerr Date: Fri, 11 Oct 2019 03:09:59 -0400 Subject: [PATCH] use list comprehension (#839) * use list comprehension * oops index range fix old-commit-hash: 686d4bbdc24df9728142fdc27245c037c7a30c7e --- common/dbc.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/common/dbc.py b/common/dbc.py index e65ee38be8..d25e7be21b 100755 --- a/common/dbc.py +++ b/common/dbc.py @@ -101,13 +101,8 @@ class dbc(): defvals = defvals.replace("?",r"\?") #escape sequence in C++ defvals = defvals.split('"')[:-1] - defs = defvals[1::2] - #cleanup, convert to UPPER_CASE_WITH_UNDERSCORES - for i,d in enumerate(defs): - d = defs[i].strip().upper() - defs[i] = d.replace(" ","_") - - defvals[1::2] = defs + # convert strings to UPPER_CASE_WITH_UNDERSCORES + defvals[1::2] = [d.strip().upper().replace(" ","_") for d in defvals[1::2]] defvals = '"'+"".join(str(i) for i in defvals)+'"' self.def_vals[ids].append((sgname, defvals))