From aaed3537780b5082d427667d6ab4070db2e7e21f Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Sat, 14 Jan 2023 03:33:03 +0800
Subject: [PATCH] cabana: use Qt::Window flag for FindSimilarBitsDlg (#26938)

use Qt::Window flag for FindSimilarBitsDlg
---
 tools/cabana/mainwin.cc               | 6 +++---
 tools/cabana/tools/findsimilarbits.cc | 4 +++-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/cabana/mainwin.cc b/tools/cabana/mainwin.cc
index 46ef8f10f9..9df5894b90 100644
--- a/tools/cabana/mainwin.cc
+++ b/tools/cabana/mainwin.cc
@@ -280,7 +280,7 @@ void MainWindow::setOption() {
 }
 
 void MainWindow::findSimilarBits() {
-  FindSimilarBitsDlg dlg(this);
-  QObject::connect(&dlg, &FindSimilarBitsDlg::openMessage, messages_widget, &MessagesWidget::selectMessage);
-  dlg.exec();
+  FindSimilarBitsDlg *dlg = new FindSimilarBitsDlg(this);
+  QObject::connect(dlg, &FindSimilarBitsDlg::openMessage, messages_widget, &MessagesWidget::selectMessage);
+  dlg->show();
 }
diff --git a/tools/cabana/tools/findsimilarbits.cc b/tools/cabana/tools/findsimilarbits.cc
index 5c9623c7e4..8a05e3e236 100644
--- a/tools/cabana/tools/findsimilarbits.cc
+++ b/tools/cabana/tools/findsimilarbits.cc
@@ -10,8 +10,10 @@
 #include "tools/cabana/canmessages.h"
 #include "tools/cabana/dbcmanager.h"
 
-FindSimilarBitsDlg::FindSimilarBitsDlg(QWidget *parent) : QDialog(parent) {
+FindSimilarBitsDlg::FindSimilarBitsDlg(QWidget *parent) : QDialog(parent, Qt::WindowFlags() | Qt::Window) {
   setWindowTitle(tr("Find similar bits"));
+  setAttribute(Qt::WA_DeleteOnClose);
+
   QVBoxLayout *main_layout = new QVBoxLayout(this);
 
   QHBoxLayout *form_layout = new QHBoxLayout();