Log more FW/VIN errors in qlogs (#25901)

* log VIN query errors

* Update fw_versions.py

* use exception

* post-commit
old-commit-hash: ba1c3cda41
taco
Shane Smiskol 3 years ago committed by GitHub
parent cfc99982c4
commit ab2eab0ffb
  1. 3
      selfdrive/car/fw_versions.py
  2. 5
      selfdrive/car/vin.py

@ -1,5 +1,4 @@
#!/usr/bin/env python3
import traceback
from collections import defaultdict
from typing import Any, Optional, Set, Tuple
from tqdm import tqdm
@ -270,7 +269,7 @@ def get_fw_versions(logcan, sendcan, query_brand=None, extra=None, timeout=0.1,
car_fw.append(f)
except Exception:
cloudlog.warning(f"FW query exception: {traceback.format_exc()}")
cloudlog.exception("FW query exception")
return car_fw

@ -1,6 +1,5 @@
#!/usr/bin/env python3
import re
import traceback
import cereal.messaging as messaging
from selfdrive.car.isotp_parallel_query import IsoTpParallelQuery
@ -28,9 +27,9 @@ def get_vin(logcan, sendcan, bus, timeout=0.1, retry=5, debug=False):
vin = vin[1:18]
return addr[0], rx_addr, vin.decode()
print(f"vin query retry ({i+1}) ...")
cloudlog.error(f"vin query retry ({i+1}) ...")
except Exception:
cloudlog.warning(f"VIN query exception: {traceback.format_exc()}")
cloudlog.exception("VIN query exception")
return 0, 0, VIN_UNKNOWN

Loading…
Cancel
Save