From b2b27ff7ee00da4b1bffa7bbe95462303b835024 Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Thu, 20 Oct 2022 22:56:28 +0800
Subject: [PATCH] cabana: improve signal highlight on hover (#26161)

* just change font color

* merge master
---
 tools/cabana/binaryview.cc | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tools/cabana/binaryview.cc b/tools/cabana/binaryview.cc
index 168edc75f4..c0ebfa9f0a 100644
--- a/tools/cabana/binaryview.cc
+++ b/tools/cabana/binaryview.cc
@@ -200,16 +200,19 @@ void BinaryItemDelegate::paint(QPainter *painter, const QStyleOptionViewItem &op
   BinaryView *bin_view = (BinaryView *)parent();
   painter->save();
 
+  bool hover = item->sig && bin_view->hoveredSignal() == item->sig;
   // background
-  QColor bg_color = item->sig && bin_view->hoveredSignal() == item->sig ? hoverColor(item->bg_color) : item->bg_color;
+  QColor bg_color = hover ? hoverColor(item->bg_color) : item->bg_color;
   if (option.state & QStyle::State_Selected) {
     bg_color = highlight_color;
   }
   painter->fillRect(option.rect, bg_color);
 
   // text
-  if (index.column() == 8) {
+  if (index.column() == 8) { // hex column
     painter->setFont(hex_font);
+  } else if (hover) {
+    painter->setPen(Qt::white);
   }
   painter->drawText(option.rect, Qt::AlignCenter, item->val);
   if (item->is_msb || item->is_lsb) {