From b3397882a373043fda1f1c7dc28cf28c0fe5eb63 Mon Sep 17 00:00:00 2001
From: Shane Smiskol <shane@smiskol.com>
Date: Fri, 12 Apr 2024 20:51:54 -0700
Subject: [PATCH] Volkswagen: enable OBD-less fingerprinting for
 gateway-integrated cars (#32188)

* too complex

* Revert "too complex"

This reverts commit 7614bfd466f26cf9b3ebf267f5a2c06d97527496.

* no logging is fine

* EPS is non-essential for exact matching
---
 selfdrive/car/volkswagen/values.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/selfdrive/car/volkswagen/values.py b/selfdrive/car/volkswagen/values.py
index 42dc2869ca..8ae2a3c430 100644
--- a/selfdrive/car/volkswagen/values.py
+++ b/selfdrive/car/volkswagen/values.py
@@ -367,7 +367,6 @@ VOLKSWAGEN_RX_OFFSET = 0x6a
 SPARE_PART_FW_PATTERN = re.compile(b'\xf1\x87(?P<gateway>[0-9][0-9A-Z]{2})(?P<unknown>[0-9][0-9A-Z][0-9])(?P<unknown2>[0-9A-Z]{2}[0-9])([A-Z0-9]| )')
 
 FW_QUERY_CONFIG = FwQueryConfig(
-  # TODO: add back whitelists after we gather enough data
   requests=[request for bus, obd_multiplexing in [(1, True), (1, False), (0, False)] for request in [
     Request(
       [VOLKSWAGEN_VERSION_REQUEST_MULTI],
@@ -375,7 +374,6 @@ FW_QUERY_CONFIG = FwQueryConfig(
       whitelist_ecus=[Ecu.srs, Ecu.eps, Ecu.fwdRadar, Ecu.fwdCamera],
       rx_offset=VOLKSWAGEN_RX_OFFSET,
       bus=bus,
-      logging=(bus != 1 or not obd_multiplexing),
       obd_multiplexing=obd_multiplexing,
     ),
     Request(
@@ -383,10 +381,10 @@ FW_QUERY_CONFIG = FwQueryConfig(
       [VOLKSWAGEN_VERSION_RESPONSE],
       whitelist_ecus=[Ecu.engine, Ecu.transmission],
       bus=bus,
-      logging=(bus != 1 or not obd_multiplexing),
       obd_multiplexing=obd_multiplexing,
     ),
   ]],
+  non_essential_ecus={Ecu.eps: list(CAR)},
   extra_ecus=[(Ecu.fwdCamera, 0x74f, None)],
 )