From b8bf3fc0c2f3f5370025c5961733b0d470732f29 Mon Sep 17 00:00:00 2001
From: Shane Smiskol <shane@smiskol.com>
Date: Thu, 20 Jul 2023 22:40:31 -0700
Subject: [PATCH] nav: improve no route alert text (#29076)

* kind of

* Revert "kind of"

This reverts commit 25abbbf1764b0f7e8fbcb83e37159ba6f8cdf641.

* more generic alert text, whenever we're waiting for navd.

* actual better comment

* update translations
old-commit-hash: d70c4916db0af3c5288034db9a361fd0aff39f7b
---
 selfdrive/ui/qt/maps/map.cc              | 3 ++-
 selfdrive/ui/translations/main_de.ts     | 4 ++--
 selfdrive/ui/translations/main_ja.ts     | 4 ++--
 selfdrive/ui/translations/main_ko.ts     | 4 ++--
 selfdrive/ui/translations/main_pt-BR.ts  | 4 ++--
 selfdrive/ui/translations/main_zh-CHS.ts | 4 ++--
 selfdrive/ui/translations/main_zh-CHT.ts | 4 ++--
 7 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/selfdrive/ui/qt/maps/map.cc b/selfdrive/ui/qt/maps/map.cc
index 2a257ab98f..7db5275bce 100644
--- a/selfdrive/ui/qt/maps/map.cc
+++ b/selfdrive/ui/qt/maps/map.cc
@@ -205,7 +205,7 @@ void MapWindow::updateState(const UIState &s) {
   if (!locationd_valid) {
     setError(tr("Waiting for GPS"));
   } else if (routing_problem) {
-    setError(tr("Waiting for internet"));
+    setError(tr("Waiting for route"));
   } else {
     setError("");
   }
@@ -237,6 +237,7 @@ void MapWindow::updateState(const UIState &s) {
     // an invalid navInstruction packet with a nav destination is only possible if:
     // - API exception/no internet
     // - route response is empty
+    // - any time navd is waiting for recompute_countdown
     auto dest = coordinate_from_param("NavDestination");
     routing_problem = !sm.valid("navInstruction") && dest.has_value();
 
diff --git a/selfdrive/ui/translations/main_de.ts b/selfdrive/ui/translations/main_de.ts
index b4282b6a9c..b165c5b34d 100644
--- a/selfdrive/ui/translations/main_de.ts
+++ b/selfdrive/ui/translations/main_de.ts
@@ -404,8 +404,8 @@
         <translation>Warten auf GPS</translation>
     </message>
     <message>
-        <source>Waiting for internet</source>
-        <translation type="unfinished">Auf Internet warten</translation>
+        <source>Waiting for route</source>
+        <translation type="unfinished"></translation>
     </message>
 </context>
 <context>
diff --git a/selfdrive/ui/translations/main_ja.ts b/selfdrive/ui/translations/main_ja.ts
index 319b08bc59..afa60e5f99 100644
--- a/selfdrive/ui/translations/main_ja.ts
+++ b/selfdrive/ui/translations/main_ja.ts
@@ -403,8 +403,8 @@
         <translation>GPS信号を探しています</translation>
     </message>
     <message>
-        <source>Waiting for internet</source>
-        <translation type="unfinished">インターネット接続を待機中</translation>
+        <source>Waiting for route</source>
+        <translation type="unfinished"></translation>
     </message>
 </context>
 <context>
diff --git a/selfdrive/ui/translations/main_ko.ts b/selfdrive/ui/translations/main_ko.ts
index d30df3a622..77ca0197c5 100644
--- a/selfdrive/ui/translations/main_ko.ts
+++ b/selfdrive/ui/translations/main_ko.ts
@@ -403,8 +403,8 @@
         <translation>GPS 수신중</translation>
     </message>
     <message>
-        <source>Waiting for internet</source>
-        <translation type="unfinished">인터넷 대기중</translation>
+        <source>Waiting for route</source>
+        <translation type="unfinished"></translation>
     </message>
 </context>
 <context>
diff --git a/selfdrive/ui/translations/main_pt-BR.ts b/selfdrive/ui/translations/main_pt-BR.ts
index 2cadd8bd6f..a4cab99951 100644
--- a/selfdrive/ui/translations/main_pt-BR.ts
+++ b/selfdrive/ui/translations/main_pt-BR.ts
@@ -404,8 +404,8 @@
         <translation>Esperando por GPS</translation>
     </message>
     <message>
-        <source>Waiting for internet</source>
-        <translation type="unfinished">Esperando pela internet</translation>
+        <source>Waiting for route</source>
+        <translation type="unfinished"></translation>
     </message>
 </context>
 <context>
diff --git a/selfdrive/ui/translations/main_zh-CHS.ts b/selfdrive/ui/translations/main_zh-CHS.ts
index 6b631b005c..508cb7304b 100644
--- a/selfdrive/ui/translations/main_zh-CHS.ts
+++ b/selfdrive/ui/translations/main_zh-CHS.ts
@@ -403,8 +403,8 @@
         <translation>等待 GPS</translation>
     </message>
     <message>
-        <source>Waiting for internet</source>
-        <translation type="unfinished">等待网络连接</translation>
+        <source>Waiting for route</source>
+        <translation type="unfinished"></translation>
     </message>
 </context>
 <context>
diff --git a/selfdrive/ui/translations/main_zh-CHT.ts b/selfdrive/ui/translations/main_zh-CHT.ts
index c9a627771e..566d8638e8 100644
--- a/selfdrive/ui/translations/main_zh-CHT.ts
+++ b/selfdrive/ui/translations/main_zh-CHT.ts
@@ -403,8 +403,8 @@
         <translation>等待 GPS</translation>
     </message>
     <message>
-        <source>Waiting for internet</source>
-        <translation type="unfinished">連接至網路中</translation>
+        <source>Waiting for route</source>
+        <translation type="unfinished"></translation>
     </message>
 </context>
 <context>