From c08e6fe35efdf45429cec625c7656ad776df2b70 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Sun, 26 Mar 2023 23:06:09 -0700 Subject: [PATCH] laikad: clean up cloudlog usage (#27701) make an error, no need to pass e old-commit-hash: 28cd8fc402bf47b119f960bd2bb511468f43d230 --- selfdrive/locationd/laikad.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/selfdrive/locationd/laikad.py b/selfdrive/locationd/laikad.py index 098b79d2e2..0c0bcbf7ef 100755 --- a/selfdrive/locationd/laikad.py +++ b/selfdrive/locationd/laikad.py @@ -223,8 +223,8 @@ class Laikad: try: ephem = parse_qcom_ephem(gnss_msg.drSvPoly, self.gps_week) self.astro_dog.add_qcom_polys({ephem.prn: [ephem]}) - except Exception as e: - cloudlog.exception(f"Error parsing qcom svPoly ephemeris from qcom module: {e}") + except Exception: + cloudlog.exception("Error parsing qcom svPoly ephemeris from qcom module") return else: @@ -232,18 +232,18 @@ class Laikad: data_struct = ephemeris_structs.Ephemeris.new_message(**gnss_msg.ephemeris.to_dict()) try: ephem = GPSEphemeris(data_struct, file_name='ublox') - except Exception as e: - cloudlog.exception(f"Error parsing GPS ephemeris from ublox: {e}") + except Exception: + cloudlog.exception("Error parsing GPS ephemeris from ublox") return elif gnss_msg.which() == 'glonassEphemeris': data_struct = ephemeris_structs.GlonassEphemeris.new_message(**gnss_msg.glonassEphemeris.to_dict()) try: ephem = GLONASSEphemeris(data_struct, file_name='ublox') - except Exception as e: - cloudlog.exception(f"Error parsing GLONASS ephemeris from ublox: {e}") + except Exception: + cloudlog.exception("Error parsing GLONASS ephemeris from ublox") return else: - cloudlog.exception(f"Unsupported ephemeris type: {gnss_msg.which()}") + cloudlog.error(f"Unsupported ephemeris type: {gnss_msg.which()}") return self.astro_dog.add_navs({ephem.prn: [ephem]}) self.cache_ephemeris()