From c76c30fa2d37d471d065e908739c69f06b43ccfe Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Thu, 3 Jun 2021 15:24:30 -0700 Subject: [PATCH] disable uploading raw by default (#21128) --- selfdrive/common/params.cc | 2 +- selfdrive/loggerd/tests/loggerd_tests_common.py | 2 +- selfdrive/loggerd/uploader.py | 2 +- selfdrive/ui/qt/offroad/settings.cc | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/selfdrive/common/params.cc b/selfdrive/common/params.cc index fbc2478556..c47f9e7997 100644 --- a/selfdrive/common/params.cc +++ b/selfdrive/common/params.cc @@ -177,7 +177,7 @@ std::unordered_map keys = { {"IsRHD", PERSISTENT}, {"IsTakingSnapshot", CLEAR_ON_MANAGER_START}, {"IsUpdateAvailable", CLEAR_ON_MANAGER_START}, - {"IsUploadRawEnabled", PERSISTENT}, + {"UploadRaw", PERSISTENT}, {"LastAthenaPingTime", PERSISTENT}, {"LastGPSPosition", PERSISTENT}, {"LastUpdateException", PERSISTENT}, diff --git a/selfdrive/loggerd/tests/loggerd_tests_common.py b/selfdrive/loggerd/tests/loggerd_tests_common.py index bc9d4cf4d2..579aaf6042 100644 --- a/selfdrive/loggerd/tests/loggerd_tests_common.py +++ b/selfdrive/loggerd/tests/loggerd_tests_common.py @@ -56,7 +56,7 @@ class MockParams(): def __init__(self): self.params = { "DongleId": b"0000000000000000", - "IsUploadRawEnabled": b"1", + "UploadRaw": b"1", "IsOffroad": b"1", } diff --git a/selfdrive/loggerd/uploader.py b/selfdrive/loggerd/uploader.py index 86fdfaee9b..9206b43158 100644 --- a/selfdrive/loggerd/uploader.py +++ b/selfdrive/loggerd/uploader.py @@ -215,7 +215,7 @@ def uploader_fn(exit_event): continue on_wifi = network_type == NetworkType.wifi - allow_raw_upload = params.get_bool("IsUploadRawEnabled") + allow_raw_upload = params.get_bool("UploadRaw") d = uploader.next_file_to_upload(with_raw=allow_raw_upload and on_wifi and offroad) if d is None: # Nothing to upload diff --git a/selfdrive/ui/qt/offroad/settings.cc b/selfdrive/ui/qt/offroad/settings.cc index 15e698e85c..39108667a2 100644 --- a/selfdrive/ui/qt/offroad/settings.cc +++ b/selfdrive/ui/qt/offroad/settings.cc @@ -49,7 +49,7 @@ TogglesPanel::TogglesPanel(QWidget *parent) : QWidget(parent) { "../assets/offroad/icon_shell.png", this)); - toggles.append(new ParamControl("IsUploadRawEnabled", + toggles.append(new ParamControl("UploadRaw", "Upload Raw Logs", "Upload full logs and full resolution video by default while on WiFi. If not enabled, individual logs can be marked for upload at my.comma.ai/useradmin.", "../assets/offroad/icon_network.png",