test_qcomgpsd: parametize tests (#31430)

* parameterize qcomgpsd

* one line
old-commit-hash: 6f4d388348
chrysler-long2
Justin Newberry 1 year ago committed by GitHub
parent f318325a25
commit c80b2283a4
  1. 11
      system/qcomgpsd/tests/test_qcomgpsd.py

@ -6,6 +6,7 @@ import time
import datetime
import unittest
import subprocess
from parameterized import parameterized
import cereal.messaging as messaging
from openpilot.system.qcomgpsd.qcomgpsd import at_cmd, wait_for_modem
@ -57,8 +58,8 @@ class TestRawgpsd(unittest.TestCase):
os.system("sudo systemctl restart ModemManager")
assert self._wait_for_output(30)
def test_startup_time(self):
for internet in (True, False):
@parameterized.expand([(b,) for b in (True, False)])
def test_startup_time(self, internet):
if not internet:
os.system("sudo systemctl stop systemd-resolved")
with self.subTest(internet=internet):
@ -66,10 +67,10 @@ class TestRawgpsd(unittest.TestCase):
assert self._wait_for_output(7)
managed_processes['qcomgpsd'].stop()
def test_turns_off_gnss(self):
for s in (0.1, 1, 5):
@parameterized.expand([(t,) for t in (0.1, 1, 5)])
def test_turns_off_gnss(self, runtime):
managed_processes['qcomgpsd'].start()
time.sleep(s)
time.sleep(runtime)
managed_processes['qcomgpsd'].stop()
ls = subprocess.check_output("mmcli -m any --location-status --output-json", shell=True, encoding='utf-8')

Loading…
Cancel
Save