better comment

pull/30893/head
Justin Newberry 2 years ago
parent db1b825d1c
commit cd39fc3214
  1. 6
      selfdrive/car/tests/test_models.py

@ -81,7 +81,6 @@ class TestCarModelBase(unittest.TestCase):
route_name = RouteName(cls.test_route.route) route_name = RouteName(cls.test_route.route)
return LogReader(f"cd:/{route_name.dongle_id}/{route_name.time_str}/{seg}/rlog.bz2") return LogReader(f"cd:/{route_name.dongle_id}/{route_name.time_str}/{seg}/rlog.bz2")
else: else:
# Attempt to use CI bucket first
return LogReader(get_url(cls.test_route.route, seg)) return LogReader(get_url(cls.test_route.route, seg))
@classmethod @classmethod
@ -130,7 +129,7 @@ class TestCarModelBase(unittest.TestCase):
@classmethod @classmethod
def get_route_data(cls, test_segs): def get_route_data(cls, test_segs):
# Attempt to get route data for one of test_segs # Attempt to get route data for one of test_segs, first trying
for seg in test_segs: for seg in test_segs:
try: try:
lr = cls.get_logreader_primary(seg) lr = cls.get_logreader_primary(seg)
@ -141,7 +140,8 @@ class TestCarModelBase(unittest.TestCase):
if not len(INTERNAL_SEG_LIST): if not len(INTERNAL_SEG_LIST):
cls.test_route_on_bucket = False cls.test_route_on_bucket = False
# fallback to public route # Route is not in CI bucket, assume either user has access (private), or it is public
# test_route_on_ci_bucket will fail when running in CI
for seg in test_segs: for seg in test_segs:
try: try:
lr = LogReader(Route(cls.test_route.route).log_paths()[seg]) lr = LogReader(Route(cls.test_route.route).log_paths()[seg])

Loading…
Cancel
Save