Ubloxd: subframe 0 is not valid (#27528)

No 0 strings
pull/27527/head
Harald Schäfer 2 years ago committed by GitHub
parent 38eea89484
commit ce900f34d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      selfdrive/locationd/ublox_msg.cc

@ -183,7 +183,7 @@ kj::Array<capnp::word> UbloxMsgParser::parse_gps_ephemeris(ubx_t::rxm_sfrbx_t *m
gps_t subframe(&stream);
int subframe_id = subframe.how()->subframe_id();
if (subframe_id > 3) {
if (subframe_id > 3 || subframe_id < 1) {
// dont parse almanac subframes
return kj::Array<capnp::word>();
}
@ -283,7 +283,7 @@ kj::Array<capnp::word> UbloxMsgParser::parse_glonass_ephemeris(ubx_t::rxm_sfrbx_
glonass_t gl_string(&stream);
int string_number = gl_string.string_number();
if (string_number > 5 || gl_string.idle_chip()) {
if (string_number < 1 || string_number > 5 || gl_string.idle_chip()) {
// dont parse non immediate data, idle_chip == 0
return kj::Array<capnp::word>();
}

Loading…
Cancel
Save