From d4c3c7f6f839652255b5d25d1517522aaf93ebe7 Mon Sep 17 00:00:00 2001
From: Adeeb <8762862+quillford@users.noreply.github.com>
Date: Sat, 1 Feb 2020 18:41:25 -0800
Subject: [PATCH] test_car_models: fail if a model has no routes (#1029)

---
 selfdrive/test/test_car_models.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/selfdrive/test/test_car_models.py b/selfdrive/test/test_car_models.py
index 0239bb8978..ddfaf58708 100755
--- a/selfdrive/test/test_car_models.py
+++ b/selfdrive/test/test_car_models.py
@@ -422,7 +422,6 @@ forced_dashcam_routes = [
 ]
 
 # TODO: replace all these with public routes
-# TODO: add routes for untested cars: HONDA ACCORD 2018 HYBRID TOURING and CHRYSLER PACIFICA 2018
 non_public_routes = [
   "0607d2516fc2148f|2019-02-13--23-03-16",  # CHRYSLER PACIFICA HYBRID 2019
   "3e9592a1c78a3d63|2018-02-08--20-28-24",  # HONDA PILOT 2017 TOURING
@@ -459,17 +458,24 @@ non_public_routes = [
   "fbd011384db5e669|2018-07-26--20-51-48",  # TOYOTA CAMRY HYBRID 2018
 ]
 
+# TODO: add routes for these cars
+non_tested_cars = [TOYOTA.LEXUS_CTH, CHRYSLER.PACIFICA_2018, HONDA.ACCORDH]
+
 if __name__ == "__main__":
 
   tested_procs = ["controlsd", "radard", "plannerd"]
   tested_socks = ["radarState", "controlsState", "carState", "plan"]
 
-  # TODO: add routes for untested cars and fail test if we have an untested car
   tested_cars = [keys["carFingerprint"] for route, keys in routes.items()]
   for car_model in all_known_cars():
     if car_model not in tested_cars:
       print("***** WARNING: %s not tested *****" % car_model)
 
+      # TODO: skip these for now, but make sure any new ports get routes
+      if car_model not in non_tested_cars:
+        print("TEST FAILED: Missing route for car '%s'" % car_model)
+        sys.exit(1)
+
   print("Preparing processes")
   for p in tested_procs:
     manager.prepare_managed_process(p)