From d810d45421aa3af9ee62fb2026aa56f1e6d4fb8a Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Mon, 1 Aug 2022 17:07:30 -0700 Subject: [PATCH] Car docs diff: print detail sentence changes (#25332) * Detail sentence changes * fix * after everything else * fix static analysis * nice emoji --- selfdrive/debug/print_docs_diff.py | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/selfdrive/debug/print_docs_diff.py b/selfdrive/debug/print_docs_diff.py index 44c821a4fc..469ceb8fe9 100755 --- a/selfdrive/debug/print_docs_diff.py +++ b/selfdrive/debug/print_docs_diff.py @@ -83,21 +83,29 @@ def print_car_info_diff(path): for new_car, base_car in car_changes: # Tier changes if base_car.tier != new_car.tier: - changes["tier"].append(f"- Tier for {base_car.make} {base_car.model} changed! ({base_car.tier.name.title()} {ARROW_SYMBOL} {new_car.tier.name.title()})") + changes["tier"].append(f"- Tier for {base_car.make} {base_car.name} changed! ({base_car.tier.name.title()} {ARROW_SYMBOL} {new_car.tier.name.title()})") # Column changes row_diff = build_column_diff(base_car, new_car) if ARROW_SYMBOL in row_diff: changes["column"].append(row_diff) + # Detail sentence changes + if base_car.detail_sentence != new_car.detail_sentence: + changes["detail"].append(f"- Sentence for {base_car.make} {base_car.name} changed!\n" + + " ```diff\n" + + f" + {base_car.detail_sentence}\n" + + f" - {new_car.detail_sentence}\n" + + "```") + # Print diff if any(len(c) for c in changes.values()): markdown_builder = ["### ⚠️ This PR makes changes to [CARS.md](../blob/master/docs/CARS.md) ⚠️"] - for title, category in (("## 🏅 Tier Changes", "tier"), ("## 🔀 Column Changes", "column"), ("## ❌ Removed", "removals"), ("## ➕ Added", "additions")): + for title, category in (("## 🏅 Tier Changes", "tier"), ("## 🔀 Column Changes", "column"), ("## ❌ Removed", "removals"), ("## ➕ Added", "additions"), ("## 📖 Detail Sentence Changes", "detail")): if len(changes[category]): markdown_builder.append(title) - if "Tier" not in title: + if category not in ("tier", "detail"): markdown_builder.append(COLUMNS) markdown_builder.append(COLUMN_HEADER) markdown_builder.extend(changes[category])