From d8a5c415cd73b50a3424a28f644466fee263e09c Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Tue, 16 Nov 2021 13:31:10 -0800 Subject: [PATCH] Revert "add offroad alerts for car unrecognized" This reverts commit fb1e8ce086ec5e2dc7b2150b62fdd99368eb7e66. --- selfdrive/common/params.cc | 2 -- selfdrive/controls/controlsd.py | 6 +----- selfdrive/controls/lib/alerts_offroad.json | 8 -------- 3 files changed, 1 insertion(+), 15 deletions(-) diff --git a/selfdrive/common/params.cc b/selfdrive/common/params.cc index 01bf9a8f4f..7e65ec128c 100644 --- a/selfdrive/common/params.cc +++ b/selfdrive/common/params.cc @@ -158,14 +158,12 @@ std::unordered_map keys = { {"ApiCache_DriveStats", PERSISTENT}, {"ApiCache_NavDestinations", PERSISTENT}, {"ApiCache_Owner", PERSISTENT}, - {"Offroad_CarUnrecognized", CLEAR_ON_MANAGER_START | CLEAR_ON_IGNITION_ON}, {"Offroad_ChargeDisabled", CLEAR_ON_MANAGER_START | CLEAR_ON_PANDA_DISCONNECT}, {"Offroad_ConnectivityNeeded", CLEAR_ON_MANAGER_START}, {"Offroad_ConnectivityNeededPrompt", CLEAR_ON_MANAGER_START}, {"Offroad_InvalidTime", CLEAR_ON_MANAGER_START}, {"Offroad_IsTakingSnapshot", CLEAR_ON_MANAGER_START}, {"Offroad_NeosUpdate", CLEAR_ON_MANAGER_START}, - {"Offroad_NoFirmware", CLEAR_ON_MANAGER_START | CLEAR_ON_IGNITION_ON}, {"Offroad_StorageMissing", CLEAR_ON_MANAGER_START}, {"Offroad_TemperatureTooHigh", CLEAR_ON_MANAGER_START}, {"Offroad_UnofficialHardware", CLEAR_ON_MANAGER_START}, diff --git a/selfdrive/controls/controlsd.py b/selfdrive/controls/controlsd.py index bbd84d458f..bd184f200f 100755 --- a/selfdrive/controls/controlsd.py +++ b/selfdrive/controls/controlsd.py @@ -22,7 +22,7 @@ from selfdrive.controls.lib.latcontrol_indi import LatControlINDI from selfdrive.controls.lib.latcontrol_lqr import LatControlLQR from selfdrive.controls.lib.latcontrol_angle import LatControlAngle from selfdrive.controls.lib.events import Events, ET -from selfdrive.controls.lib.alertmanager import AlertManager, set_offroad_alert +from selfdrive.controls.lib.alertmanager import AlertManager from selfdrive.controls.lib.vehicle_model import VehicleModel from selfdrive.locationd.calibrationd import Calibration from selfdrive.hardware import HARDWARE, TICI, EON @@ -170,10 +170,6 @@ class Controls: self.events.add(EventName.communityFeatureDisallowed, static=True) if not car_recognized: self.events.add(EventName.carUnrecognized, static=True) - if len(self.CP.carFw) > 0: - set_offroad_alert("Offroad_CarUnrecognized", True) - else: - set_offroad_alert("Offroad_NoFirmware", True) elif self.read_only: self.events.add(EventName.dashcamMode, static=True) elif self.joystick_mode: diff --git a/selfdrive/controls/lib/alerts_offroad.json b/selfdrive/controls/lib/alerts_offroad.json index 34f7601b3f..9a863551a8 100644 --- a/selfdrive/controls/lib/alerts_offroad.json +++ b/selfdrive/controls/lib/alerts_offroad.json @@ -40,13 +40,5 @@ "Offroad_StorageMissing": { "text": "Storage drive not mounted.", "severity": 1 - }, - "Offroad_CarUnrecognized": { - "text": "openpilot was unable to identify your car... TODO", - "severity": 0 - }, - "Offroad_NoFirmware": { - "text": "openpilot was unable to identify your car (no fw)... TODO", - "severity": 0 } }