From d9ca45ed1b2bc0316aad8ff11470e1a9b96fb09c Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Fri, 9 Sep 2022 02:56:39 +0800
Subject: [PATCH] map_helpers: pass parameters by const reference (#25701)

pass parameters by const reference
---
 selfdrive/ui/qt/maps/map_helpers.cc | 6 +++---
 selfdrive/ui/qt/maps/map_helpers.h  | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/selfdrive/ui/qt/maps/map_helpers.cc b/selfdrive/ui/qt/maps/map_helpers.cc
index f97137a7f9..ca81545f7f 100644
--- a/selfdrive/ui/qt/maps/map_helpers.cc
+++ b/selfdrive/ui/qt/maps/map_helpers.cc
@@ -56,7 +56,7 @@ QMapbox::CoordinatesCollections model_to_collection(
   return collections;
 }
 
-QMapbox::CoordinatesCollections coordinate_to_collection(QMapbox::Coordinate c) {
+QMapbox::CoordinatesCollections coordinate_to_collection(const QMapbox::Coordinate &c) {
   QMapbox::Coordinates coordinates;
   coordinates.push_back(c);
 
@@ -85,7 +85,7 @@ QMapbox::CoordinatesCollections capnp_coordinate_list_to_collection(const capnp:
 
 }
 
-QMapbox::CoordinatesCollections coordinate_list_to_collection(QList<QGeoCoordinate> coordinate_list) {
+QMapbox::CoordinatesCollections coordinate_list_to_collection(const QList<QGeoCoordinate> &coordinate_list) {
   QMapbox::Coordinates coordinates;
 
   for (auto &c : coordinate_list) {
@@ -143,7 +143,7 @@ QList<QGeoCoordinate> polyline_to_coordinate_list(const QString &polylineString)
   return path;
 }
 
-std::optional<QMapbox::Coordinate> coordinate_from_param(std::string param) {
+std::optional<QMapbox::Coordinate> coordinate_from_param(const std::string &param) {
   QString json_str = QString::fromStdString(Params().get(param));
   if (json_str.isEmpty()) return {};
 
diff --git a/selfdrive/ui/qt/maps/map_helpers.h b/selfdrive/ui/qt/maps/map_helpers.h
index 2e1402ccea..6bd5b0f067 100644
--- a/selfdrive/ui/qt/maps/map_helpers.h
+++ b/selfdrive/ui/qt/maps/map_helpers.h
@@ -21,10 +21,10 @@ QMapbox::CoordinatesCollections model_to_collection(
   const cereal::LiveLocationKalman::Measurement::Reader &calibratedOrientationECEF,
   const cereal::LiveLocationKalman::Measurement::Reader &positionECEF,
   const cereal::ModelDataV2::XYZTData::Reader &line);
-QMapbox::CoordinatesCollections coordinate_to_collection(QMapbox::Coordinate c);
+QMapbox::CoordinatesCollections coordinate_to_collection(const QMapbox::Coordinate &c);
 QMapbox::CoordinatesCollections capnp_coordinate_list_to_collection(const capnp::List<cereal::NavRoute::Coordinate>::Reader &coordinate_list);
-QMapbox::CoordinatesCollections coordinate_list_to_collection(QList<QGeoCoordinate> coordinate_list);
+QMapbox::CoordinatesCollections coordinate_list_to_collection(const QList<QGeoCoordinate> &coordinate_list);
 QList<QGeoCoordinate> polyline_to_coordinate_list(const QString &polylineString);
 
-std::optional<QMapbox::Coordinate> coordinate_from_param(std::string param);
+std::optional<QMapbox::Coordinate> coordinate_from_param(const std::string &param);
 double angle_difference(double angle1, double angle2);