sadmen
/
openpilot_comma
mirror of https://github.com/commaai/openpilot.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

map_helpers: pass parameters by const reference (#25701)

Browse Source 
pass parameters by const reference
pull/25706/head^2
Dean Lee 3 years ago committed by GitHub
parent 015090de92
commit d9ca45ed1b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 6
      selfdrive/ui/qt/maps/map_helpers.cc
  2. 6
      selfdrive/ui/qt/maps/map_helpers.h

6
selfdrive/ui/qt/maps/map_helpers.cc
Unescape View File

@ -56,7 +56,7 @@ QMapbox::CoordinatesCollections model_to_collection(
return collections; return collections;
} }
QMapbox::CoordinatesCollections coordinate_to_collection(QMapbox::Coordinate c) { QMapbox::CoordinatesCollections coordinate_to_collection(const QMapbox::Coordinate &c) {
QMapbox::Coordinates coordinates; QMapbox::Coordinates coordinates;
coordinates.push_back(c); coordinates.push_back(c);
@ -85,7 +85,7 @@ QMapbox::CoordinatesCollections capnp_coordinate_list_to_collection(const capnp:
} }
QMapbox::CoordinatesCollections coordinate_list_to_collection(QList<QGeoCoordinate> coordinate_list) { QMapbox::CoordinatesCollections coordinate_list_to_collection(const QList<QGeoCoordinate> &coordinate_list) {
QMapbox::Coordinates coordinates; QMapbox::Coordinates coordinates;
for (auto &c : coordinate_list) { for (auto &c : coordinate_list) {
@ -143,7 +143,7 @@ QList<QGeoCoordinate> polyline_to_coordinate_list(const QString &polylineString)
return path; return path;
} }
std::optional<QMapbox::Coordinate> coordinate_from_param(std::string param) { std::optional<QMapbox::Coordinate> coordinate_from_param(const std::string &param) {
QString json_str = QString::fromStdString(Params().get(param)); QString json_str = QString::fromStdString(Params().get(param));
if (json_str.isEmpty()) return {}; if (json_str.isEmpty()) return {};

6
selfdrive/ui/qt/maps/map_helpers.h
Unescape View File

@ -21,10 +21,10 @@ QMapbox::CoordinatesCollections model_to_collection(
const cereal::LiveLocationKalman::Measurement::Reader &calibratedOrientationECEF, const cereal::LiveLocationKalman::Measurement::Reader &calibratedOrientationECEF,
const cereal::LiveLocationKalman::Measurement::Reader &positionECEF, const cereal::LiveLocationKalman::Measurement::Reader &positionECEF,
const cereal::ModelDataV2::XYZTData::Reader &line); const cereal::ModelDataV2::XYZTData::Reader &line);
QMapbox::CoordinatesCollections coordinate_to_collection(QMapbox::Coordinate c); QMapbox::CoordinatesCollections coordinate_to_collection(const QMapbox::Coordinate &c);
QMapbox::CoordinatesCollections capnp_coordinate_list_to_collection(const capnp::List<cereal::NavRoute::Coordinate>::Reader &coordinate_list); QMapbox::CoordinatesCollections capnp_coordinate_list_to_collection(const capnp::List<cereal::NavRoute::Coordinate>::Reader &coordinate_list);
QMapbox::CoordinatesCollections coordinate_list_to_collection(QList<QGeoCoordinate> coordinate_list); QMapbox::CoordinatesCollections coordinate_list_to_collection(const QList<QGeoCoordinate> &coordinate_list);
QList<QGeoCoordinate> polyline_to_coordinate_list(const QString &polylineString); QList<QGeoCoordinate> polyline_to_coordinate_list(const QString &polylineString);
std::optional<QMapbox::Coordinate> coordinate_from_param(std::string param); std::optional<QMapbox::Coordinate> coordinate_from_param(const std::string &param);
double angle_difference(double angle1, double angle2); double angle_difference(double angle1, double angle2);

Write Preview
Loading…
Cancel
Save