From db061e0e7adedd9cb11943a2c36df03957cf9ab6 Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Fri, 14 Oct 2022 04:25:21 +0800 Subject: [PATCH] Cabana: scrollable binary view (#26065) old-commit-hash: a397418ef82957289779cbfbcf9cb138d9f2cd3f --- tools/cabana/detailwidget.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/cabana/detailwidget.cc b/tools/cabana/detailwidget.cc index 7c1847230b..531cd4c665 100644 --- a/tools/cabana/detailwidget.cc +++ b/tools/cabana/detailwidget.cc @@ -141,17 +141,14 @@ BinaryView::BinaryView(QWidget *parent) { table->horizontalHeader()->setSectionResizeMode(QHeaderView::Stretch); table->horizontalHeader()->hide(); table->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff); - table->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff); main_layout->addWidget(table); table->setColumnCount(9); - setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Fixed); } void BinaryView::setMessage(const QString &message_id) { msg_id = message_id; const Msg *msg = dbc()->msg(msg_id); - int row_count = msg ? msg->size : can->lastMessage(msg_id).dat.size(); - + const int row_count = msg ? msg->size : can->lastMessage(msg_id).dat.size(); table->setRowCount(row_count); table->setColumnCount(9); for (int i = 0; i < table->rowCount(); ++i) { @@ -178,8 +175,7 @@ void BinaryView::setMessage(const QString &message_id) { } } } - - table->setFixedHeight(table->rowHeight(0) * table->rowCount() + table->horizontalHeader()->height() + 2); + table->setFixedHeight(table->rowHeight(0) * std::min(row_count, 8) + 2); updateState(); }