From db252b457a01bc35414e9d25c0fc6abcc4e3a949 Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Tue, 19 Apr 2022 11:07:54 -0700 Subject: [PATCH] improve tici thermal control (#24228) * improve tici thermals * more i * always 70 old-commit-hash: c5378cf8b923446269b7c207451a9804b6f862b0 --- selfdrive/thermald/fan_controller.py | 4 +- tools/plotjuggler/layouts/thermal_debug.xml | 92 +++++++++++++++++++++ 2 files changed, 94 insertions(+), 2 deletions(-) create mode 100644 tools/plotjuggler/layouts/thermal_debug.xml diff --git a/selfdrive/thermald/fan_controller.py b/selfdrive/thermald/fan_controller.py index fd9de2ac0f..b1c7013297 100644 --- a/selfdrive/thermald/fan_controller.py +++ b/selfdrive/thermald/fan_controller.py @@ -18,7 +18,7 @@ class TiciFanController(BaseFanController): cloudlog.info("Setting up TICI fan handler") self.last_ignition = False - self.controller = PIDController(k_p=0, k_i=2e-3, k_f=1, neg_limit=-80, pos_limit=0, rate=(1 / DT_TRML)) + self.controller = PIDController(k_p=0, k_i=4e-3, k_f=1, neg_limit=-80, pos_limit=0, rate=(1 / DT_TRML)) def update(self, max_cpu_temp: float, ignition: bool) -> int: self.controller.neg_limit = -(80 if ignition else 30) @@ -27,7 +27,7 @@ class TiciFanController(BaseFanController): if ignition != self.last_ignition: self.controller.reset() - error = 75 - max_cpu_temp + error = 70 - max_cpu_temp fan_pwr_out = -int(self.controller.update( error=error, feedforward=interp(max_cpu_temp, [60.0, 100.0], [0, -80]) diff --git a/tools/plotjuggler/layouts/thermal_debug.xml b/tools/plotjuggler/layouts/thermal_debug.xml new file mode 100644 index 0000000000..fbb89ddcf4 --- /dev/null +++ b/tools/plotjuggler/layouts/thermal_debug.xml @@ -0,0 +1,92 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +