From db8d4c8ff7ec4be62453a7dadb9b2bf6f82184c4 Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Sun, 29 Jan 2023 04:03:59 +0800 Subject: [PATCH] cabana: remove extra frame border in logs (#27133) remove extra frame border old-commit-hash: 07b32750c16fe4e71abbf81e07aa839ac60b5343 --- tools/cabana/historylog.cc | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tools/cabana/historylog.cc b/tools/cabana/historylog.cc index a2a90e4f0c..ccc2c5533d 100644 --- a/tools/cabana/historylog.cc +++ b/tools/cabana/historylog.cc @@ -195,8 +195,13 @@ void HeaderView::paintSection(QPainter *painter, const QRect &rect, int logicalI LogsWidget::LogsWidget(QWidget *parent) : QWidget(parent) { QVBoxLayout *main_layout = new QVBoxLayout(this); + main_layout->setContentsMargins(0, 0, 0, 0); + main_layout->setSpacing(0); + + QWidget *toolbar = new QWidget(this); + toolbar->setAutoFillBackground(true); + QHBoxLayout *h = new QHBoxLayout(toolbar); - QHBoxLayout *h = new QHBoxLayout(); filters_widget = new QWidget(this); QHBoxLayout *filter_layout = new QHBoxLayout(filters_widget); filter_layout->setContentsMargins(0, 0, 0, 0); @@ -215,7 +220,11 @@ LogsWidget::LogsWidget(QWidget *parent) : QWidget(parent) { dynamic_mode->setChecked(true); dynamic_mode->setEnabled(!can->liveStreaming()); - main_layout->addLayout(h); + main_layout->addWidget(toolbar); + QFrame *line = new QFrame(this); + line->setFrameStyle(QFrame::HLine | QFrame::Sunken); + main_layout->addWidget(line);; + main_layout->addWidget(logs = new QTableView(this)); logs->setModel(model = new HistoryLogModel(this)); logs->setItemDelegateForColumn(1, new MessageBytesDelegate(this)); @@ -223,6 +232,7 @@ LogsWidget::LogsWidget(QWidget *parent) : QWidget(parent) { logs->horizontalHeader()->setDefaultAlignment(Qt::AlignLeft | (Qt::Alignment)Qt::TextWordWrap); logs->horizontalHeader()->setSectionResizeMode(QHeaderView::ResizeToContents); logs->verticalHeader()->setVisible(false); + logs->setFrameShape(QFrame::NoFrame); QObject::connect(display_type_cb, SIGNAL(activated(int)), model, SLOT(setDisplayType(int))); QObject::connect(dynamic_mode, &QCheckBox::stateChanged, model, &HistoryLogModel::setDynamicMode);