Change the term "Non-US" to "South America" for the "Corolla Hybrid (Non-US only) 2020-23" entry (#32658)
The term "Non-US" in cars.md for the "Corolla Hybrid (Non-US only) 2020-23" is not precise enough and should be changed to South America Users may think "Non-US" includes Europe or Canada, which is not the case for this entry. It has two issues: * The 2023 Corolla Hybrid in Europe and Canada include a new Toyota Safety Sense 3.0 that has yet to be supported due to it being a new version and the presence of Toyota Security Key. * The 2020-2022 Corolla Hybrid in Europe is the same as the 2020-2022 Corolla Hybrid in North America, which is supported by Openpilot and has full-speed ACC due to the presence of an electronic parking brake which is not present in the 2020-2022 Corolla Hybrid in South America and the reason why it is listed as not having full-speed ACC. The entry should be reverted to at least "Corolla Hybrid (South America) 2020-23" which was proposed but not merged in the pull request:09728454c04cc
Pull request for that change that does not include that commit: https://github.com/commaai/openpilot/pull/26943 Examples of confusion throughout the community: comma.ai Discord: https://discord.com/channels/469524606043160576/524327905937850394/1235264758580772996 https://discord.com/channels/469524606043160576/524327905937850394/1228090600272691370 https://discord.com/channels/469524606043160576/954493346250887168/1209952008329633813 https://discord.com/channels/469524606043160576/524327905937850394/1182093384647721140 https://discord.com/channels/469524606043160576/954493346250887168/1147751657543848017 openpilot community Discord: https://discord.com/channels/771493367246094347/771495215570747403/1247737844727021629 > I think that the supported cars list (https://github.com/commaai/openpilot/blob/master/docs/CARS.md) is incorrect. > > I have a UK 2020 Toyota Corolla Hybrid > > In the cars list it's listed as "no accel below" 17 mph and no resume from > stop. > > This is not my experience. For me it works just fine down to a complete stop and it can resume from a stop too. > > CC: @AlexandreSato old-commit-hash:3b6862030a
parent
ae8f9da48d
commit
dfd4374739
2 changed files with 2 additions and 2 deletions
Loading…
Reference in new issue