Volkswagen: log FW on non-OBD buses (#31556)

* log lots

* update refs

* cmt
old-commit-hash: 72a7f008ab
pull/32199/head
Shane Smiskol 2 years ago committed by GitHub
parent 1219678ef1
commit e0322ba82f
  1. 4
      selfdrive/car/tests/test_fw_fingerprint.py
  2. 15
      selfdrive/car/volkswagen/values.py

@ -263,7 +263,7 @@ class TestFwFingerprintTiming(unittest.TestCase):
print(f'get_vin {name} case, query time={self.total_time / self.N} seconds')
def test_fw_query_timing(self):
total_ref_time = {1: 6.05, 2: 6.95}
total_ref_time = {1: 6.5, 2: 7.4}
brand_ref_times = {
1: {
'gm': 0.5,
@ -277,7 +277,7 @@ class TestFwFingerprintTiming(unittest.TestCase):
'subaru': 0.45,
'tesla': 0.2,
'toyota': 1.6,
'volkswagen': 0.2,
'volkswagen': 0.65,
},
2: {
'ford': 0.3,

@ -293,17 +293,24 @@ VOLKSWAGEN_VERSION_RESPONSE = bytes([uds.SERVICE_TYPE.READ_DATA_BY_IDENTIFIER +
VOLKSWAGEN_RX_OFFSET = 0x6a
FW_QUERY_CONFIG = FwQueryConfig(
requests=[
# TODO: add back whitelists after we gather enough data
requests=[request for bus, obd_multiplexing in [(1, True), (1, False), (0, False)] for request in [
Request(
[VOLKSWAGEN_VERSION_REQUEST_MULTI],
[VOLKSWAGEN_VERSION_RESPONSE],
whitelist_ecus=[Ecu.srs, Ecu.eps, Ecu.fwdRadar],
# whitelist_ecus=[Ecu.srs, Ecu.eps, Ecu.fwdRadar],
rx_offset=VOLKSWAGEN_RX_OFFSET,
bus=bus,
logging=(bus != 1 or not obd_multiplexing),
obd_multiplexing=obd_multiplexing,
),
Request(
[VOLKSWAGEN_VERSION_REQUEST_MULTI],
[VOLKSWAGEN_VERSION_RESPONSE],
whitelist_ecus=[Ecu.engine, Ecu.transmission],
# whitelist_ecus=[Ecu.engine, Ecu.transmission],
bus=bus,
logging=(bus != 1 or not obd_multiplexing),
obd_multiplexing=obd_multiplexing,
),
],
]],
)

Loading…
Cancel
Save